Commit Graph

546 Commits

Author SHA1 Message Date
Dan Abramov
c9e99c8ae6 Avoid unnecessary ternary 2018-06-11 02:05:28 +01:00
Dan Abramov
c70187cdbf Cross-link more articles 2018-06-11 02:01:34 +01:00
Dan Abramov
a788a28708 Avoid ambiguity between elements and components 2018-06-11 00:36:52 +01:00
Dan Abramov
3346d710b9 Clarify we are talking about sync calls 2018-06-10 23:03:13 +01:00
Dan Abramov
4550cb0e6a Massage the section more and add details 2018-06-10 22:53:22 +01:00
Jenny Wong
941c1a4efc NOtes and ideas for hello-world.md file.
- you can _just_ open it in 
- It _renders_ a heading saying “Hello, world!” on the page.  - you are using the same  word as the thing you are describing. 
- “A Note on JavaScript”  the title doe snot suggest that you need to read it because you are learning about react ,not JS.  Something like  “React & JavaScript” or something like “Knowledge Level Assumptions”
- “we recommend **refreshing** your JavaScript knowledge so you can follow along more easily.” — refreshing suggest that someone. Already knows JS, so if they don’t know JS they will feel dejected. Try “We highly recommend [going through a Javascript tutorial]() to check your knowledge level.”
- “We also use some of the ES6 syntax”  - **We**  that suggests its a  us vs  the user.  Instead go for “**The documentation** will use some [ES6 Syntax](LINK TO WHAT IS ES6)”
2018-06-10 22:53:22 +01:00
Dan Abramov
640ac1397b No "just" 2018-06-10 21:58:13 +01:00
Dan Abramov
f285d002c5 Reduce visual noise in the list
It's obvious enough that this is the same method. I don't think repeating its name in the list brings any value, and it puts too much visual emphasis on something we're trying to deemphasize.
2018-06-10 21:51:09 +01:00
Dan Abramov
4f01e35b9d Rewrite some component doc parts 2018-06-10 21:38:44 +01:00
Dan Abramov
6fe2302aed Don’t make experienced users feel bad 2018-06-10 19:30:53 +01:00
Dan Abramov
7603eb964b Mark common lifecycles as bold (#948) 2018-06-10 19:02:25 +01:00
Dan Abramov
79411aa85b Reorder and rewrite some parts of lifecycle reference (#947)
* Reorder and rewrite some parts of lifecycle reference

* Link to the lifecycle diagram

* More recommendations
2018-06-10 18:26:32 +01:00
Sébastien Boulet
95112711bb fix link to anchor #unsafe_componentwillupdate (#920) 2018-05-31 13:10:53 +01:00
Sophie Alpert
3e87993047 Move static type checking above PropTypes 2018-05-29 09:47:37 -07:00
Brian Vaughn
3e80980c18 Renamed params for gDSFP 2018-05-24 18:18:04 -07:00
Andrew Clark
dfaf1eecba Merge pull request #904 from acdlite/16.4-release-post
16.4 blog post
2018-05-23 17:58:16 -07:00
Andrew Clark
983476e3f3 Update getDerivedStateFromProps docs 2018-05-23 15:31:27 -07:00
Philipp Spiess
a1f41f65a2 Don’t recommend PEP because it lacks features 2018-05-23 14:28:42 -07:00
Philipp Spiess
988a67739d Add section about Pointer Events
This PR adds a section about the state of Pointer Events in React.

This should be merged only if facebook/react#12507 is accepted as well.
2018-05-23 14:28:30 -07:00
John Park
665ccbf907 Missing closing quotation in line 225 for <Button /> (#905) 2018-05-23 21:04:29 +01:00
pushpinder107
06f8553e90 Fixes typo (#902) 2018-05-23 12:48:45 +01:00
Brian Vaughn
822fc42852 Merge pull request #891 from cyan33/warn-legacy-context-in-strict-mode
add #Detecting legacy context apis for strict mode post
2018-05-22 15:42:33 -07:00
Dan Burzo
1d5217a293 Clarify change propagation in Context API (#896) 2018-05-21 14:01:22 +01:00
barnonahill
9b72ba6f05 Add a sentence to the end of componentWillUnmount() (#894)
Adds a sentence explaining not to use setState in componentWillUnmount, see https://github.com/facebook/react/issues/12111
2018-05-20 23:52:19 +01:00
cyan33
5ce098c1a1 refactor the wording 2018-05-18 14:56:07 -07:00
cyan33
1b5cf20dcc add #detecting legacy context apis for strict mode post 2018-05-17 14:40:47 -07:00
Tung Vu
1f8fdac9cc doc: add createRef to Refs glossary (#875)
* doc: add createRef to Refs glossary

* doc: move newer api first
2018-05-12 14:24:27 +01:00
Stephane Moreau
f03e9c785d "Introducing JSX" is missing a step (#812)
* Introducing JSX is missing a step

* Tweak
2018-05-09 18:19:39 +01:00
Alex Krolick
c95de8b59a Clarify defaultValue usage (#868)
Fixes #867
2018-05-07 23:48:13 -07:00
Duc Nghiem Xuan
d0cdc9ef0c Fix elmish-react link on static-type-checking (#857)
`fable-elmish` org is now simply `elmish`, thus the link to `elmish-react` was 404.

ref https://github.com/elmish/elmish/issues/145
2018-05-02 01:00:27 -07:00
Dan Abramov
e3cf355618 Tweak componentWillReceiveProps docs (#856)
* Tweak componentWillReceiveProps docs

* Update reference-react-component.md
2018-05-01 13:11:08 +01:00
Rauno Freiberg
3279bd768b Fix JSX link in design principles section (#855) 2018-04-30 14:51:22 -07:00
Chester Law
f97629e6f0 Fix grammar in List and Keys documentation (#854) 2018-04-30 13:43:24 -07:00
Augustus Yuan
f1bdc9674e Replace meeting notes section with RFCS section (#848) 2018-04-27 22:07:37 +01:00
Eugene Kopich
f40682a583 new "Flow" URL (2) (#839) 2018-04-25 11:39:58 +01:00
Eugene Kopich
b147d01e75 new "Flow" URL (#838) 2018-04-24 18:24:05 +01:00
Jedai Saboteur
049c40109d Linked to an example "from scratch" implementation (#837)
* Add link to complete example

* Fix heading space on complete example
2018-04-24 10:04:14 +01:00
Joep van der Heijden
1c9b6139c4 Add missing semicolon in example code (#835) 2018-04-23 14:38:26 +01:00
Almero Steyn
cd4bc8b341 Merge pull request #797 from jlr7245/jlr7245-add-chromevox
add chromevox to a11y documentation
2018-04-23 07:36:26 +02:00
Michael Li
ed255e604b Fix grammar 2018-04-22 00:37:19 -04:00
J Silverstein
380225e65e add chromevox to a11y documentation 2018-04-20 13:51:46 -04:00
John
a4aa51035a docs(error-boundaries):fix react blog link (#817) 2018-04-17 18:20:30 +01:00
John
233d74e790 docs(error-boundaries):remove react beta reference (#815) 2018-04-17 16:59:05 +01:00
Marc Bouchard
5593059434 docs(refs-and-the-dom): typo in CustomTextInput (#813)
Correct a typo in the render method comments for the "CustomTextInput" component of the "Adding a Ref to a DOM Element" example.  The first line of the comments reads "tell React that we want the associate the <input> ref".  The word "the" should be "to" resulting in the comment "tell React that we want to associate the <input> ref".
2018-04-17 02:37:06 +01:00
Dan Abramov
04124cc053 Promote ref forwarding in "DOM and Refs" (#802) 2018-04-13 18:17:11 +01:00
Lucas Duailibe
dab9b8b2fd Add 'visual components' use case for forwarding refs (#798)
* Add 'visual components' use case for forwarding refs

* Rearrange "forwarding refs" to focus on simple use case

* Minor wording nits to 2018-03-29-react-v-16-3.md

* Minor wording nits to forwarding-refs.md

* Add more info to the forwardRef reference doc

* Minor wording nits to reference-react.md
2018-04-13 17:23:19 +01:00
Brian Vaughn
d453c2c8fb Merge pull request #767 from koba04/customizing-display-name-ref-forwarding
Add a section "Customizing Name in DevTools" in Forwarding Refs
2018-04-11 08:17:28 -07:00
Brian Vaughn
e26547bfc6 Wording nit 2018-04-11 08:16:05 -07:00
Toru Kobayashi
f450adbdec Add a section "Displaying a custom name in DevTools" 2018-04-11 11:56:17 +09:00
Alex Krolick
d7f675d418 "efficient" is vague 2018-04-10 16:29:30 -07:00