Dan Abramov
c9e99c8ae6
Avoid unnecessary ternary
2018-06-11 02:05:28 +01:00
Dan Abramov
c70187cdbf
Cross-link more articles
2018-06-11 02:01:34 +01:00
Dan Abramov
a788a28708
Avoid ambiguity between elements and components
2018-06-11 00:36:52 +01:00
Alex Krolick
cec61969ea
Fix CI ( #952 )
...
* Checksum against lockfile
* Use Node 8 Docker image
2018-06-10 15:22:09 -07:00
Dan Abramov
3346d710b9
Clarify we are talking about sync calls
2018-06-10 23:03:13 +01:00
Dan Abramov
4550cb0e6a
Massage the section more and add details
2018-06-10 22:53:22 +01:00
Jenny Wong
941c1a4efc
NOtes and ideas for hello-world.md file.
...
- you can _just_ open it in
- It _renders_ a heading saying “Hello, world!” on the page. - you are using the same word as the thing you are describing.
- “A Note on JavaScript” the title doe snot suggest that you need to read it because you are learning about react ,not JS. Something like “React & JavaScript” or something like “Knowledge Level Assumptions”
- “we recommend **refreshing** your JavaScript knowledge so you can follow along more easily.” — refreshing suggest that someone. Already knows JS, so if they don’t know JS they will feel dejected. Try “We highly recommend [going through a Javascript tutorial]() to check your knowledge level.”
- “We also use some of the ES6 syntax” - **We** that suggests its a us vs the user. Instead go for “**The documentation** will use some [ES6 Syntax](LINK TO WHAT IS ES6)”
2018-06-10 22:53:22 +01:00
Dan Abramov
640ac1397b
No "just"
2018-06-10 21:58:13 +01:00
Dan Abramov
f285d002c5
Reduce visual noise in the list
...
It's obvious enough that this is the same method. I don't think repeating its name in the list brings any value, and it puts too much visual emphasis on something we're trying to deemphasize.
2018-06-10 21:51:09 +01:00
Dan Abramov
03c0046f7b
Try to fix iPhone horizontal scroll in Component reference
2018-06-10 21:50:01 +01:00
Dan Abramov
4f01e35b9d
Rewrite some component doc parts
2018-06-10 21:38:44 +01:00
Dan Abramov
6fe2302aed
Don’t make experienced users feel bad
2018-06-10 19:30:53 +01:00
Dan Abramov
7603eb964b
Mark common lifecycles as bold ( #948 )
2018-06-10 19:02:25 +01:00
Dan Abramov
79411aa85b
Reorder and rewrite some parts of lifecycle reference ( #947 )
...
* Reorder and rewrite some parts of lifecycle reference
* Link to the lifecycle diagram
* More recommendations
2018-06-10 18:26:32 +01:00
Dan Abramov
846ab6c383
Clarify it's not a recommended approach
2018-06-10 18:10:37 +01:00
Brian Vaughn
a5f0b2a251
Typo fix
2018-06-08 10:32:45 -04:00
Brian Vaughn
e51668cb51
Merge pull request #941 from bvaughn/typo-fix
...
Fix typo
2018-06-07 23:24:38 -04:00
Brian Vaughn
fc0c2bc154
Fix typo
2018-06-07 23:23:19 -04:00
Brian Vaughn
0cb3144880
Merge pull request #934 from bvaughn/when-to-use-derived-state
...
You Probably Don't Need Derived State
2018-06-07 17:31:46 -04:00
Brian Vaughn
125bd2b52e
Bullet point organization
2018-06-07 17:31:30 -04:00
Brian Vaughn
292f3bc4a0
Two small nits
2018-06-07 17:29:38 -04:00
Sophie Alpert
2925bc2d7e
Edit derived state post
2018-06-07 16:58:05 -04:00
Brian Vaughn
e18db03ccf
Added more Code Sandbox links for alternative patterns
2018-06-07 11:38:09 -04:00
Brian Vaughn
ddc134f894
Added more Code Sandbox demo links
2018-06-07 10:43:41 -04:00
Brian Vaughn
ca2d3bbaff
Clarified a point
2018-06-07 08:44:51 -04:00
Brian Vaughn
d9b4cf4d0b
Change section headers
2018-06-06 15:04:14 -04:00
Brian Vaughn
452203c3a1
Tweaked wording based on feedback
2018-06-06 14:20:56 -04:00
Brian Vaughn
07017de81a
Added emphasis suggested by Ryan
2018-06-06 14:11:35 -04:00
Brian Vaughn
1296f0c869
Wording nit
2018-06-06 14:09:07 -04:00
Brian Vaughn
64f9bff41d
Grammar nit
2018-06-06 14:00:15 -04:00
Brian Vaughn
22c1a4620e
Refactored blog post to include cWRP too
2018-06-06 13:51:00 -04:00
Brian Vaughn
f97b54d54d
More confident wording
2018-06-06 12:04:26 -04:00
Brian Vaughn
80bd61b8a3
Title: You Probably Don't Need Derived State
2018-06-06 12:03:07 -04:00
Brian Vaughn
ad799f7e6f
"an although" -> "and although"
2018-06-05 22:34:08 -04:00
Brian Vaughn
faa2ac956a
Replace en dash (–) with em dash (—)
2018-06-05 22:28:57 -04:00
Brian Vaughn
cd8602fbab
Removed a 'just'
2018-06-05 22:26:48 -04:00
Brian Vaughn
056a87ce34
props.id -> props.userID
2018-06-05 22:25:52 -04:00
Brian Vaughn
79e68e4b76
em dash -> comma
2018-06-05 22:23:24 -04:00
Brian Vaughn
92e18dcfd7
Break up a sentence
2018-06-05 22:22:03 -04:00
Brian Vaughn
247cd92b87
Let's take a look at each of the alternatives.
2018-06-05 22:19:35 -04:00
Brian Vaughn
b0aea104de
Small explanation of the terms 'controlled' and 'uncontrolled'
2018-06-05 22:16:38 -04:00
Brian Vaughn
8a6d25500e
Changed the opening blurb
2018-06-05 22:04:57 -04:00
Brian Vaughn
f5b7b76d30
Updated Code Sandbox links. Mentioned Redux.
2018-06-05 21:12:11 -04:00
Dan Abramov
51ff2c88d9
Match casing nit
2018-06-06 00:10:37 +01:00
Dan Abramov
6ec35c784a
Add another comment to PureComponent example
2018-06-06 00:05:16 +01:00
Dan Abramov
ff9dc0bab2
Move handleChange above render
2018-06-05 23:48:13 +01:00
Dan Abramov
eba7131ed1
Drop the should
2018-06-05 23:47:01 +01:00
Dan Abramov
ef0b3b773d
Explain memoization
2018-06-05 23:46:23 +01:00
Brian Vaughn
df89e03ad7
Expanded memoization section
2018-06-05 18:15:13 -04:00
Brian Vaughn
1d3ff0d059
Reworded recap section based on Dan's input
2018-06-05 18:07:18 -04:00
