amirho/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2026-02-21 19:31:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

[Perf Tracks] Handle arrays with bigints in deep objects (#35648)

Browse Source
This commit is contained in:
Sebastian "Sebbie" Silbermann
2026-01-28 11:54:50 +01:00
committed by GitHub
parent e66ef6480e
commit ff191f24b5
2 changed files with 86 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

83
packages/react-reconciler/src/__tests__/ReactPerformanceTrack-test.js vendored
View File

@@ -440,4 +440,87 @@ describe('ReactPerformanceTracks', () => {
]);
performanceMeasureCalls.length = 0;
});
// @gate __DEV__ && enableComponentPerformanceTrack
it('can handle bigint in arrays', async () => {
const App = function App({numbers}) {
Scheduler.unstable_advanceTime(10);
React.useEffect(() => {}, [numbers]);
};
Scheduler.unstable_advanceTime(1);
await act(() => {
ReactNoop.render(
<App
data={{
deeply: {
nested: {
numbers: [1n],
},
},
}}
/>,
);
});
expect(performanceMeasureCalls).toEqual([
[
'Mount',
{
detail: {
devtools: {
color: 'warning',
properties: null,
tooltipText: 'Mount',
track: 'Components ⚛',
},
},
end: 11,
start: 1,
},
],
]);
performanceMeasureCalls.length = 0;
Scheduler.unstable_advanceTime(10);
await act(() => {
ReactNoop.render(
<App
data={{
deeply: {
nested: {
numbers: [2n],
},
},
}}
/>,
);
});
expect(performanceMeasureCalls).toEqual([
[
'​App',
{
detail: {
devtools: {
color: 'primary-dark',
properties: [
['Changed Props', ''],
['  data', ''],
['    deeply', ''],
['      nested', ''],
['–       numbers', 'Array'],
['+       numbers', 'Array'],
],
tooltipText: 'App',
track: 'Components ⚛',
},
},
end: 31,
start: 21,
},
],
]);
});
});

4
packages/shared/ReactPerformanceTrackProperties.js
View File

@@ -16,7 +16,7 @@ import getComponentNameFromType from './getComponentNameFromType';
const EMPTY_ARRAY = 0;
const COMPLEX_ARRAY = 1;
const PRIMITIVE_ARRAY = 2; // Primitive values only
const PRIMITIVE_ARRAY = 2; // Primitive values only that are accepted by JSON.stringify
const ENTRIES_ARRAY = 3; // Tuple arrays of string and value (like Headers, Map, etc)
// Showing wider objects in the devtools is not useful.
@@ -46,6 +46,8 @@ function getArrayKind(array: Object): 0 | 1 | 2 | 3 {
return COMPLEX_ARRAY;
} else if (kind !== EMPTY_ARRAY && kind !== PRIMITIVE_ARRAY) {
return COMPLEX_ARRAY;
} else if (typeof value === 'bigint') {
return COMPLEX_ARRAY;
} else {
kind = PRIMITIVE_ARRAY;
}