amirho/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2026-02-21 19:31:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert "Performance tracks are sorted by start time" hack (#31518)

Browse Source 
This reverts commit d3bf32a958 which was
part of #30983

When you have very deep trees this trick can cause the top levels to
skew way too much from the real numbers. Creating unbalanced trees.

The bug should have been fixed in Chrome Canary now so that entries
added later are sorted to go first which should've addressed this issue.
This commit is contained in:
Sebastian Markbåge
2024-11-12 12:46:55 -05:00
committed by GitHub
parent 2ec26bc432
commit d9b3841ca6
1 changed files with 2 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
packages/react-reconciler/src/ReactProfilerTimer.js vendored
View File

@@ -193,13 +193,8 @@ export function popComponentEffectStart(prevEffectStart: number): void {
if (!enableProfilerTimer || !enableProfilerCommitHooks) {
return;
}
if (prevEffectStart < 0) {
// If the parent component didn't have a start time, we use the start
// of the child as the parent's start time. We subtrack a minimal amount of
// time to ensure that the parent's start time is before the child to ensure
// that the performance tracks line up in the right order.
componentEffectStartTime -= 0.001;
} else {
// If the parent component didn't have a start time, we let this current time persist.
if (prevEffectStart >= 0) {
// Otherwise, we restore the previous parent's start time.
componentEffectStartTime = prevEffectStart;
}