[flags] enable owner stacks everywhere (#32376)

this is now canary and on everywhere
This commit is contained in:
Ricky
2025-02-18 10:29:40 -05:00
committed by GitHub
parent 4632e36a4e
commit 8a7b487e3b
9 changed files with 17 additions and 14 deletions

View File

@@ -25,7 +25,5 @@ export const enableShallowPropDiffing = __VARIANT__;
export const passChildrenWhenCloningPersistedNodes = __VARIANT__;
export const enableSiblingPrerendering = __VARIANT__;
export const enableUseEffectCRUDOverload = __VARIANT__;
export const enableOwnerStacks = __VARIANT__;
export const enableRemoveConsolePatches = __VARIANT__;
export const enableFastAddPropertiesInDiffing = __VARIANT__;
export const enableLazyPublicInstanceInFabric = __VARIANT__;

View File

@@ -27,12 +27,14 @@ export const {
enableUseEffectCRUDOverload,
passChildrenWhenCloningPersistedNodes,
enableSiblingPrerendering,
enableOwnerStacks,
enableRemoveConsolePatches,
enableFastAddPropertiesInDiffing,
enableLazyPublicInstanceInFabric,
} = dynamicFlags;
// These two can be removed
export const enableOwnerStacks = true;
export const enableRemoveConsolePatches = true;
// The rest of the flags are static for better dead code elimination.
export const disableClientCache = true;
export const disableCommentsAsDOMContainers = true;

View File

@@ -40,7 +40,7 @@ export const enableLegacyFBSupport = false;
export const enableLegacyHidden = false;
export const enableNoCloningMemoCache = false;
export const enableObjectFiber = false;
export const enableOwnerStacks = false;
export const enableOwnerStacks = true;
export const enablePersistedModeClonedFlag = false;
export const enablePostpone = false;
export const enableReactTestRendererWarning = false;
@@ -80,7 +80,7 @@ export const enableProfilerTimer = __PROFILE__;
export const enableProfilerCommitHooks = __PROFILE__;
export const enableProfilerNestedUpdatePhase = __PROFILE__;
export const enableUpdaterTracking = __PROFILE__;
export const enableRemoveConsolePatches = false;
export const enableRemoveConsolePatches = true;
// Flow magic to verify the exports of this file match the original version.
((((null: any): ExportsType): FeatureFlagsType): ExportsType);

View File

@@ -35,7 +35,7 @@ export const enableLegacyFBSupport = false;
export const enableLegacyHidden = false;
export const enableNoCloningMemoCache = false;
export const enableObjectFiber = false;
export const enableOwnerStacks = false;
export const enableOwnerStacks = true;
export const enablePersistedModeClonedFlag = false;
export const enablePostpone = false;
export const enableProfilerCommitHooks = __PROFILE__;
@@ -67,8 +67,8 @@ export const enableHydrationLaneScheduling = true;
export const enableYieldingBeforePassive = false;
export const enableThrottledScheduling = false;
export const enableViewTransition = false;
export const enableRemoveConsolePatches = true;
export const enableSwipeTransition = false;
export const enableRemoveConsolePatches = false;
export const enableFastAddPropertiesInDiffing = false;
export const enableLazyPublicInstanceInFabric = false;

View File

@@ -70,7 +70,7 @@ export const disableDefaultPropsExceptForClasses = true;
export const renameElementSymbol = false;
export const enableObjectFiber = false;
export const enableOwnerStacks = false;
export const enableOwnerStacks = true;
export const enableShallowPropDiffing = false;
export const enableSiblingPrerendering = true;
@@ -82,8 +82,8 @@ export const enableYieldingBeforePassive = false;
export const enableThrottledScheduling = false;
export const enableViewTransition = false;
export const enableRemoveConsolePatches = true;
export const enableSwipeTransition = false;
export const enableRemoveConsolePatches = false;
export const enableFastAddPropertiesInDiffing = false;
export const enableLazyPublicInstanceInFabric = false;

View File

@@ -26,7 +26,6 @@ export const enableRetryLaneExpiration = __VARIANT__;
export const enableTransitionTracing = __VARIANT__;
export const favorSafetyOverHydrationPerf = __VARIANT__;
export const renameElementSymbol = __VARIANT__;
export const enableOwnerStacks = __VARIANT__;
export const retryLaneExpirationMs = 5000;
export const syncLaneExpirationMs = 250;
export const transitionLaneExpirationMs = 5000;
@@ -37,7 +36,6 @@ export const enableInfiniteRenderLoopDetection = __VARIANT__;
export const enableSiblingPrerendering = __VARIANT__;
export const enableUseEffectCRUDOverload = __VARIANT__;
export const enableRemoveConsolePatches = __VARIANT__;
export const enableFastAddPropertiesInDiffing = __VARIANT__;
export const enableLazyPublicInstanceInFabric = false;
export const enableViewTransition = __VARIANT__;

View File

@@ -35,8 +35,6 @@ export const {
retryLaneExpirationMs,
syncLaneExpirationMs,
transitionLaneExpirationMs,
enableOwnerStacks,
enableRemoveConsolePatches,
enableFastAddPropertiesInDiffing,
enableViewTransition,
} = dynamicFeatureFlags;
@@ -44,6 +42,10 @@ export const {
// On WWW, __EXPERIMENTAL__ is used for a new modern build.
// It's not used anywhere in production yet.
// Can remove these two
export const enableOwnerStacks = true;
export const enableRemoveConsolePatches = true;
export const enableProfilerTimer = __PROFILE__;
export const enableProfilerCommitHooks = __PROFILE__;
export const enableProfilerNestedUpdatePhase = __PROFILE__;

View File

@@ -11,6 +11,7 @@ jest.mock('shared/ReactFeatureFlags', () => {
// Flags that aren't currently used, but we still want to force variants to keep the
// code live.
actual.disableInputAttributeSyncing = __VARIANT__;
actual.enableOwnerStacks = __VARIANT__;
// These are hardcoded to true for the next release,
// but still run the tests against both variants until

View File

@@ -11,6 +11,8 @@ jest.mock('shared/ReactFeatureFlags', () => {
'shared/forks/ReactFeatureFlags.native-fb.js'
);
actual.enableOwnerStacks = __VARIANT__;
// Lots of tests use these, but we don't want to expose it to RN.
// Ideally, tests for xplat wouldn't use react-dom, but many of our tests do.
// Since the xplat tests run with the www entry points, some of these flags