amirho/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2026-02-21 19:31:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

[compiler] fix bad rebase from sapling (#35145)

Browse Source 
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/35145).
* #35144
* __->__ #35145
This commit is contained in:
Joseph Savona
2025-11-14 14:50:38 -08:00
committed by GitHub
parent 19b769fa5f
commit 647e13366c
2 changed files with 0 additions and 58 deletions
Download Patch File Download Diff File Expand all files Collapse all files

43
compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/new-mutability/error.todo-repro-destructure-from-prop-with-default-value.expect.md
View File

@@ -1,43 +0,0 @@
## Input
```javascript
export function useFormatRelativeTime(opts = {}) {
const {timeZone, minimal} = opts;
const format = useCallback(function formatWithUnit() {}, [minimal]);
// We record `{timeZone}` as capturing timeZone into the object,
// then assume that dateTimeFormat() mutates that object,
// which in turn can mutate timeZone and the object it came from,
// which means that the value `minimal` is derived from can change.
//
// The bug is that we shouldn't be recording a Capture effect given
// that `opts` is known maybe-frozen. If we correctly recorded
// an ImmutableCapture, this wouldn't be mistaken as mutating
// opts/minimal
dateTimeFormat({timeZone});
return format;
}
```
## Error
```
Found 1 error:
Compilation Skipped: Existing memoization could not be preserved
React Compiler has skipped optimizing this component because the existing manual memoization could not be preserved. This dependency may be mutated later, which could cause the value to change unexpectedly.
error.todo-repro-destructure-from-prop-with-default-value.ts:3:60
1 | export function useFormatRelativeTime(opts = {}) {
2 | const {timeZone, minimal} = opts;
> 3 | const format = useCallback(function formatWithUnit() {}, [minimal]);
| ^^^^^^^ This dependency may be modified later
4 | // We record `{timeZone}` as capturing timeZone into the object,
5 | // then assume that dateTimeFormat() mutates that object,
6 | // which in turn can mutate timeZone and the object it came from,
```

15
compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/new-mutability/error.todo-repro-destructure-from-prop-with-default-value.js
View File

@@ -1,15 +0,0 @@
export function useFormatRelativeTime(opts = {}) {
const {timeZone, minimal} = opts;
const format = useCallback(function formatWithUnit() {}, [minimal]);
// We record `{timeZone}` as capturing timeZone into the object,
// then assume that dateTimeFormat() mutates that object,
// which in turn can mutate timeZone and the object it came from,
// which means that the value `minimal` is derived from can change.
//
// The bug is that we shouldn't be recording a Capture effect given
// that `opts` is known maybe-frozen. If we correctly recorded
// an ImmutableCapture, this wouldn't be mistaken as mutating
// opts/minimal
dateTimeFormat({timeZone});
return format;
}