amirho/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2026-02-26 01:05:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

Avoid lastProps[key] lookup in initial render

Browse Source 
This makes both Firefox and IE 15-20% faster in initial render (!!). On my PE benchmark, createElement is now on par with HTML in Firefox and faster in IE11 (before, it was slower).
This commit is contained in:
Ben Alpert
2015-10-24 12:19:30 -07:00
parent 6269ef62cf
commit 22a240fd39
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/renderers/dom/shared/ReactDOMComponent.js
View File

@@ -665,7 +665,7 @@ ReactDOMComponent.Mixin = {
DOMPropertyOperations.setAttributeForID(el, this._rootNodeID);
// Populate node cache
ReactMount.getID(el);
this._updateDOMProperties({}, props, transaction);
this._updateDOMProperties(null, props, transaction);
var lazyTree = DOMLazyTree(el);
this._createInitialChildren(transaction, props, context, lazyTree);
mountImage = lazyTree;
@@ -964,9 +964,9 @@ ReactDOMComponent.Mixin = {
}
for (propKey in nextProps) {
var nextProp = nextProps[propKey];
var lastProp = propKey === STYLE ?
this._previousStyleCopy :
lastProps[propKey];
var lastProp =
propKey === STYLE ? this._previousStyleCopy :
lastProps != null ? lastProps[propKey] : undefined;
if (!nextProps.hasOwnProperty(propKey) ||
nextProp === lastProp ||
nextProp == null && lastProp == null) {