Commit Graph

4761 Commits

Author SHA1 Message Date
Arshita Kakkar
cc007751ca Documentation correction (#2304)
* Documentation error

Line 290 - ". However, instead we recommend to split state into multiple state variables based on which values tend to change together."
Both 'however' and 'instead' are contrasting words and only one of them should be used. 
Either "Instead we recommend to split state into multiple state variables based on which values tend to change together." OR "However, we recommend to split state into multiple state variables based on which values tend to change together."
Updated the sentence.

* Updated 'however' to 'instead'

Line 290 updated to - 
Instead, **we recommend to split state into multiple state variables based on which values tend to change together.**

* Update hooks-faq.md

Co-authored-by: Sunil Pai <threepointone@fb.com>
2020-03-09 13:34:04 +00:00
Joe Del
1695e26dc8 fix broken link to babel repl on jsx-compiler page (#2349) 2020-03-09 13:28:21 +00:00
Conrad Beach
257a7dbca3 Fix Typo in Lifting State Up Docs (#2395)
There's a line in the document that says:
"When it previously rendered, the `Calculator` has specified that"

The sentence is using a present tense verb ("has"), but the statement is in the past tense.

I think "When it previously rendered, the `Calculator` had specified that" would be correct.
2020-03-09 13:24:47 +00:00
Jermaine de Bruyne
5435c31693 Update README.md (improve usability) (#2398)
* Update README.md (improve usability) 

Clear up the ambiguous "Running locally" to the anchor link for better usability

* Update README.md

Co-authored-by: Sunil Pai <threepointone@oculus.com>
2020-03-09 13:23:49 +00:00
Tom Beckenhauer
e3a6479989 Update legacy lifecycle methods (#2435)
* Update legacy lifecycle methods

componentWillReceiveProps -> componentDidUpdate

* Update legacy lifecycle methods

componentWillReceiveProps -> componentDidUpdate

* Update higher-order-components.md

Co-authored-by: Sunil Pai <threepointone@oculus.com>
2020-03-09 13:16:24 +00:00
Bob Ziroll
5f594efaf8 Fix typo on React 16 Roadmap page (#2433)
I believe it was meant to be "news story", but I could be misunderstanding something in the context of the paragraph.
2020-03-09 13:14:05 +00:00
Christopher Wray
6603bdea3d Updated sentence grammar. (#2459) 2020-03-09 13:07:41 +00:00
Juan M. Rinaudo
ec355d122f add missing word (#2479)
Co-authored-by: Juan Manuel Rinaudo <juan.rinaudo@jemstep.com>
Co-authored-by: Sunil Pai <threepointone@fb.com>
2020-03-09 13:06:51 +00:00
Kevin Sullivan
705cacfa70 Update concurrent-mode-suspense.md (#2495)
According to [ProofreadNOW](https://www.proofreadnow.com/blog/bid/101485/If-I-Were-or-If-I-Was-Which-is-Correct),
> Guideline: Use were (instead of was) in statements that are contrary to fact.
2020-03-09 13:03:31 +00:00
项鸿伟
7c28a3e88a Update testing-recipes.md (#2509)
Missing code
2020-03-09 13:02:00 +00:00
David Cho-Lerat
81681dda2a Fix small typo in concurrent-mode-adoption.md (#2531)
"You can use in new code" => "You can use them in new code"
2020-03-09 12:55:30 +00:00
Matt Wood
a1f0f84a1f Update components docs for functional components (#2547)
* Update components docs for functional components

* Update components-and-props.md

Co-authored-by: Sunil Pai <threepointone@oculus.com>
2020-03-09 12:52:33 +00:00
David Cho-Lerat
778ddf16a2 Fix small typo in concurrent-mode-reference.md (#2533)
`MySlowList` "lag behind" => `MySlowList` "lags behind"
2020-03-09 12:49:50 +00:00
yosuheee
9ae0305c6b Update testing-recipes.md (#2573)
- correcting assertion mistakes
2020-03-09 12:41:51 +00:00
amdwit
70826654df Update components-and-props.md (#2601) 2020-03-09 12:33:38 +00:00
Sergei Cherniaev
922daf1add typo fix, double spaces (#2608) 2020-03-09 12:33:04 +00:00
mknapper1
fe5ec2c55d Fix typo in hooks-faq.md (#2649)
* Fix typo in hooks-faq.md

* Update hooks-faq.md

* Update hooks-faq.md

Co-authored-by: Sophie Alpert <git@sophiebits.com>
Co-authored-by: Sunil Pai <threepointone@oculus.com>
2020-03-09 12:21:12 +00:00
Aviv Hadar
602bfb5eda Update hooks-reference.md (#2691)
Clarifying  a useState sentence
2020-03-09 12:08:46 +00:00
Abdulaziz Sirojiddinov
902918e162 adding next section path (#2741)
adding the next section path at the end.
2020-03-09 12:02:48 +00:00
Abdulaziz Sirojiddinov
0c6d760ab5 adding next section url path (#2742)
adding next section URL path at the end in order to ease readers follow steps
2020-03-09 12:02:22 +00:00
38elements
b39931e98a Fix og:image (#2745) 2020-03-09 12:01:49 +00:00
Sunil Pai
87b4a4fac7 Revert "added stackblitz to playground (#2759)" (#2820)
This reverts commit 869c740a88.
2020-03-09 11:56:39 +00:00
Pato
869c740a88 added stackblitz to playground (#2759)
* added stackblitz to playground

* modified link of Stackblitz

I changed the link based on comment from @EricSimons
2020-03-09 11:56:15 +00:00
J Zhong
bbc6419a36 Add link to download node.js in Create React App (#2787) 2020-03-09 11:44:55 +00:00
Muhammad Arslan Sajid
69b15a2117 update hooks-faq.md (#2806)
1- Added getDerivedStateFromError lifecycle method to "Do Hooks cover all use cases for classes?"
2- Added getSnapshotBeforeUpdate lifecycle method to "How do lifecycle methods correspond to Hooks?"
2020-03-09 11:36:19 +00:00
Daniel Emod Kovacs
aa177081e0 fix: extract instantiation of Remarkable (#2813) 2020-03-09 11:35:19 +00:00
Balázs Orbán
78793ef90d move Hungarian to in progress (#2818) 2020-03-09 11:30:16 +00:00
Vishal Jagtap
21d5ecef80 Added Pune (India) Meetup Communiy (#2808) 2020-03-08 20:32:55 +03:00
Ryan James
616807556f s/'a myriad of'/'myriad' (#2764)
Think of "myriad" as a number. You wouldn't say "a nine of things", you would say "nine things".
2020-03-06 17:09:25 -08:00
Karl Horky
33f93b7b04 Move past conferences to bottom of page (#2816) 2020-03-06 13:02:23 -08:00
Sunil Pai
c9b76e9795 fix test renderer's act() example (#2811)
`<renderer>.update()` doesn't return anything
2020-03-04 12:48:44 +00:00
Sunil Pai
60d83be9be Add shouldComponentUpdate to list of methods double called in Strict Mode (#2810)
This landed in 16.13 via https://github.com/facebook/react/pull/17942
2020-03-04 12:34:58 +00:00
Luis Filipe
a9ab627e09 Update rendering-elements.md (#2804)
Link each mention of a React API in rendering-elements.md to the reference docs.

On this page replace every static occurrence of `ReactDOM.render()` by link to the reference docs [`ReactDOM.render()`](/docs/react-dom.html#render)

Is this in the right direction @sophiebits ? 🤔 

ref #2630
2020-03-03 18:33:16 -08:00
Sinan Aksay
2ab1ca5007 fixed the bracket (#2796) 2020-03-01 18:01:03 +03:00
Sinan Aksay
03a151590f added ReactJS Istanbul (#2792) 2020-03-01 16:34:55 +03:00
Sunil Pai
c95c5cb123 Add Edge extension link for Devtools (#2790)
* add Edge extension link for Devtools

* Update 2015-09-02-new-react-developer-tools.md
2020-02-29 18:27:04 +00:00
Dan Abramov
c1d4960a2a Remove shallow renderer from website navigation (#2785)
We still support it (and you can find this page in search), but we're transitioning away to community maintenance.
So we're deemphasizing it on the website.
2020-02-27 18:19:33 +00:00
Dan Abramov
df492156d3 Add redirect from old blog post url (#2784)
* Add redirect from old blog post url

* Update 2020-02-26-react-v16.13.0.md
2020-02-27 02:58:11 +00:00
Sean McPherson
770cb59d6c Use semantic button for event handler example (#2781)
As a general rule, `onClick` handlers should not be applied to non-interactive elements like a `div`. There is not substantive change to the code sample, but it doesn't provide a better example of semantic HTML for developers reading the documentation.
2020-02-26 15:31:43 -08:00
Sunil Pai
a2813dc864 fix 16.13 blog post date (#2782)
as well the right link to the changelog
2020-02-26 22:36:06 +00:00
Brian Vaughn
d89ca50a06 Updated CHANGELOG to remove passive effects change from 16.13 release. (It wasn't part of that release.) 2020-02-26 13:10:49 -08:00
Dan Abramov
7f56986243 Fix wrong version 2020-02-26 20:55:30 +00:00
Sunil Pai
1b5c6d3d13 Blog post for v16.13.0 (#2779)
* Blogpost for v16.13.0

* Tweak

* Update 2020-03-02-react-v16.13.0.md

* update react/react-dom versions

Co-authored-by: Dan Abramov <dan.abramov@gmail.com>
2020-02-26 20:44:54 +00:00
James Cool
bba6229e90 Fix broken link (#2776)
* Fix broken link

* change underscores to hyphens

Previous fix not correct. This actually fixes the link.
2020-02-24 13:27:06 -08:00
nanaki14
821e207262 fix: 🐛 Update conferences.md (#2735) 2020-02-24 13:24:23 +03:00
Patrick Smith
0741c81a14 "async" mode to "concurrent" mode (#2761)
Should hooks such as `useLayoutEffect`, `useEffect`, etc also be listed in the "Render phase lifecycles" section?
2020-02-20 09:17:03 -08:00
Jamie Dixon
2746927f56 Add the word 'a' to 'whole seven seconds' to complete sentence (#2757) 2020-02-20 09:00:38 +03:00
Levi Notik
9fea635692 Minor grammatical fix (#2747)
Change 

> node whose contents has changed 

to

> node whose contents have changed
2020-02-18 12:51:35 -08:00
Kin Lum
285902c381 "Here" as the title for link has no semantics (#2751)
A page could have 50 links, every one with the link text "Here" and it doesn't mean anything.
Search engines rely on the fact that the link text says something about the link. The text "Here" doesn't mean anything to search engines.  Using "Here" as link text has no semantic value.
2020-02-18 12:43:07 -08:00
Brent Mulligan
5af5fba65a Remove dead link (#2743) 2020-02-16 18:56:01 +03:00