Commit Graph

4797 Commits

Author SHA1 Message Date
Sunil Pai
287dfde7bb add missing documentation URLs to /versions 2020-03-14 13:50:18 +00:00
Dan Abramov
b3c7540a10 Update building instructions 2020-03-14 13:34:15 +00:00
Fran Zekan
91ffdb0812 Upgrade to Node 12 LTS (#2831)
* Upgrade to node 12 LTS

* Run prettier
2020-03-14 13:24:39 +00:00
Vishal Jagtap
be17215d86 Updated React and React Native links (#2824)
* DOC: Updated the React Native Home URL

* Blog: Updated the React URL Link

* Relative link added
2020-03-12 13:24:06 +00:00
Jonathan Chhabra
617021f886 Make React.memo documentation more clear (#2762)
* Make React.memo documentation more clear

* Update reference-react.md

Co-authored-by: Sunil Pai <threepointone@fb.com>
2020-03-10 10:37:44 +00:00
David Beitey
d1c1c30ea0 Clarify preferred "props default to true" expr (#495)
* Clarify preferred "props default to true" expr

The current text is ambiguous without reading further into the paragraph -- until I re-read this text, I was trying to avoid both types of syntax because it seemed to imply that it wans't recommended (eg "props default to true" --> "we don't recommend using this").

* Update jsx-in-depth.md

Co-authored-by: Sunil Pai <threepointone@oculus.com>
2020-03-09 20:39:04 +00:00
JuanMa
56cea09a36 docs(render-props): examples improvement suggestion (#987) 2020-03-09 19:41:27 +00:00
Mendel Bakaleynik
98d8c10769 Minor grammar edit (syntactic -> syntactical). (#1043)
* Minor grammar edit (syntactic -> syntactical).

* Update handling-events.md

Co-authored-by: Sunil Pai <threepointone@oculus.com>
2020-03-09 19:33:56 +00:00
Andy
c44f4e577d Use const for ref in functional component docs (#1129)
Co-authored-by: Sunil Pai <threepointone@fb.com>
2020-03-09 18:42:08 +00:00
Mo Ismat
420fc316c5 Update 2018-06-07-you-probably-dont-need-derived-state.md (#1173)
Grammar/typo
2020-03-09 18:33:34 +00:00
Paul Henschel
6f322a438a Update conditional-rendering.md (#1175)
The ternary syntax using parenthesis was an unconventional prettier invention, going out of its way to format react ternaries differently from normal ternaries (if i remember correctly, because vim users had trouble re-formating without a mouse). If they made the right decision or not is one thing, but the additional noise could mislead beginners here, thinking they have to add more characters to make a simple 2-slot ternary, or that it is a "react thing".
2020-03-09 18:30:53 +00:00
Maddie Kreamer
970e90a4e6 apostrophe added to Facebooks to show possession (#1297) 2020-03-09 17:55:49 +00:00
Stephanie
7611c776fc Remove event from arrow function example (#1542) 2020-03-09 16:24:44 +00:00
Ruslan Petrov
d58c947b1e Update motivation-solution.js (#1625)
Removed unused props for clarity.
2020-03-09 16:06:53 +00:00
Ruslan Petrov
16647b39e6 Update reference-caveats-problem.js (#1626)
Added MyContext for clarity.
2020-03-09 16:02:47 +00:00
Michal Srb
59ff52aa82 Remove implicit boolean conversion from homepage example (#1781)
We shouldn't be encouraging this pattern which requires good understanding of JS quirks and can lead to bugs in other instances.
2020-03-09 15:41:40 +00:00
Toru Kobayashi
331eb9db01 remove a reference to fbjs from codebase overview (#1806)
* remove a reference to fbjs from codebase overview

* Update codebase-overview.md

Co-authored-by: Sunil Pai <threepointone@oculus.com>
2020-03-09 15:40:40 +00:00
Luan Ferreira
6f0a32dab7 Fix tiny typo in is-react-translated-yet blog post (#1833) 2020-03-09 15:31:52 +00:00
Sai Ram Kunala
348a5b2888 add suffix / to example url (#1861)
was inconsistent across examples
2020-03-09 15:27:31 +00:00
Amandeep Singh
fb382ccb13 Update render-props.md (#1940) 2020-03-09 15:02:50 +00:00
Param Aggarwal
9fa6418ada Update core-js import calls as per v3 (#1971) 2020-03-09 14:55:29 +00:00
Carl A Lewis
6c108015ae Update code-splitting.md (#1972)
Added some clarity.
2020-03-09 14:54:30 +00:00
Raj Nigam
79d33dfe6e unused React import for hooks example (#1979)
I believe this was just from a copy/paste from the JSX example
2020-03-09 14:49:48 +00:00
shawn
3140018914 Update getting-started.md (#1991) 2020-03-09 14:40:52 +00:00
Sunil Pai
30749ed0b2 Revert "Revert "added stackblitz to playground (#2759)" (#2820)" (#2821)
This reverts commit 87b4a4fac7.
2020-03-09 14:17:59 +00:00
Karl Horky
911abf97ce Improve grammar (#2045) 2020-03-09 14:09:53 +00:00
Myron Yeung
ba0818beab Fix ref creation in CustomTextInput component (#2072)
Change React.createRef() to useRef(null)
2020-03-09 14:06:19 +00:00
Gisli Nielsen
63a06196ba Changed what a component compiles to. (#2075) 2020-03-09 14:05:24 +00:00
Himanshu Pathak
c477cd79c8 animation plugin moved (#2091)
`react-addons-css-transition-group` moved to `react-transition-group`
2020-03-09 14:01:38 +00:00
Abel Regalado
be8775d4b9 [docs] Add missing events to docs/events page (#2123)
* [docs] Add missing evens to docs/events page

Added missing `onReset` event to Form Events –– (https://reactjs.org/docs/events.html#form-events)
Created Generic Events subsection, and added `onError` & `onLoad` events –– (https://reactjs.org/docs/events.html#generic-events)

Based on @sophiebits suggestion in following thread:
https://github.com/facebook/react/issues/1718#issuecomment-122622933

* [docs] Add event subsection to #supported-events

Added Generic Events subsection under Supported Events (https://reactjs.org/docs/events.html#supported-events)
2020-03-09 13:58:23 +00:00
tiffanymonroe
efeaea0606 added commas for clarification and grammar (#2133) 2020-03-09 13:54:51 +00:00
corinty
bc060f5edd Moved a bracket in the setState function example (#2164) 2020-03-09 13:52:38 +00:00
Vincent
b4e7437ceb Link to relevant forwardRef docs (#2229) 2020-03-09 13:48:48 +00:00
Rajinder Yadav
a35a95fb4b Handling Multiple Inputs (#2260)
Text says to use "__name__" but code shows usage of "__type__".
2020-03-09 13:45:57 +00:00
Steve Dodier-Lazaro
2c8f5695ba Add reference to persist to SyntheticEvent's API (#2274)
Since persist() is referred to in the doc as a method for disabling event pooling, that must mean it's part of the SyntheticEvent API.

I'm proposing to state it more explicitly so that there's no doubt for newcomers like me whether it is the SyntheticEvent or the actual JS event that has the method.
2020-03-09 13:41:13 +00:00
Arshita Kakkar
5fc494752c Doc error (#2301)
Changed Line 94- You can't use Hooks *inside* of a class component, but you can definitely mix classes and function components with Hooks in a single tree.  
to 
"You can't use Hooks *inside* a class component, but you can definitely mix classes and function components with Hooks in a single tree. "
2020-03-09 13:35:18 +00:00
Arshita Kakkar
cc007751ca Documentation correction (#2304)
* Documentation error

Line 290 - ". However, instead we recommend to split state into multiple state variables based on which values tend to change together."
Both 'however' and 'instead' are contrasting words and only one of them should be used. 
Either "Instead we recommend to split state into multiple state variables based on which values tend to change together." OR "However, we recommend to split state into multiple state variables based on which values tend to change together."
Updated the sentence.

* Updated 'however' to 'instead'

Line 290 updated to - 
Instead, **we recommend to split state into multiple state variables based on which values tend to change together.**

* Update hooks-faq.md

Co-authored-by: Sunil Pai <threepointone@fb.com>
2020-03-09 13:34:04 +00:00
Joe Del
1695e26dc8 fix broken link to babel repl on jsx-compiler page (#2349) 2020-03-09 13:28:21 +00:00
Conrad Beach
257a7dbca3 Fix Typo in Lifting State Up Docs (#2395)
There's a line in the document that says:
"When it previously rendered, the `Calculator` has specified that"

The sentence is using a present tense verb ("has"), but the statement is in the past tense.

I think "When it previously rendered, the `Calculator` had specified that" would be correct.
2020-03-09 13:24:47 +00:00
Jermaine de Bruyne
5435c31693 Update README.md (improve usability) (#2398)
* Update README.md (improve usability) 

Clear up the ambiguous "Running locally" to the anchor link for better usability

* Update README.md

Co-authored-by: Sunil Pai <threepointone@oculus.com>
2020-03-09 13:23:49 +00:00
Tom Beckenhauer
e3a6479989 Update legacy lifecycle methods (#2435)
* Update legacy lifecycle methods

componentWillReceiveProps -> componentDidUpdate

* Update legacy lifecycle methods

componentWillReceiveProps -> componentDidUpdate

* Update higher-order-components.md

Co-authored-by: Sunil Pai <threepointone@oculus.com>
2020-03-09 13:16:24 +00:00
Bob Ziroll
5f594efaf8 Fix typo on React 16 Roadmap page (#2433)
I believe it was meant to be "news story", but I could be misunderstanding something in the context of the paragraph.
2020-03-09 13:14:05 +00:00
Christopher Wray
6603bdea3d Updated sentence grammar. (#2459) 2020-03-09 13:07:41 +00:00
Juan M. Rinaudo
ec355d122f add missing word (#2479)
Co-authored-by: Juan Manuel Rinaudo <juan.rinaudo@jemstep.com>
Co-authored-by: Sunil Pai <threepointone@fb.com>
2020-03-09 13:06:51 +00:00
Kevin Sullivan
705cacfa70 Update concurrent-mode-suspense.md (#2495)
According to [ProofreadNOW](https://www.proofreadnow.com/blog/bid/101485/If-I-Were-or-If-I-Was-Which-is-Correct),
> Guideline: Use were (instead of was) in statements that are contrary to fact.
2020-03-09 13:03:31 +00:00
项鸿伟
7c28a3e88a Update testing-recipes.md (#2509)
Missing code
2020-03-09 13:02:00 +00:00
David Cho-Lerat
81681dda2a Fix small typo in concurrent-mode-adoption.md (#2531)
"You can use in new code" => "You can use them in new code"
2020-03-09 12:55:30 +00:00
Matt Wood
a1f0f84a1f Update components docs for functional components (#2547)
* Update components docs for functional components

* Update components-and-props.md

Co-authored-by: Sunil Pai <threepointone@oculus.com>
2020-03-09 12:52:33 +00:00
David Cho-Lerat
778ddf16a2 Fix small typo in concurrent-mode-reference.md (#2533)
`MySlowList` "lag behind" => `MySlowList` "lags behind"
2020-03-09 12:49:50 +00:00
yosuheee
9ae0305c6b Update testing-recipes.md (#2573)
- correcting assertion mistakes
2020-03-09 12:41:51 +00:00