Commit Graph

2639 Commits

Author SHA1 Message Date
ishank
14c7494eab changed wording slightly 2017-10-10 22:52:10 +05:30
ishank
a3445b3ce6 changed wording 2017-10-10 22:28:51 +05:30
Brian Vaughn
a66e63b575 Merge pull request #107 from TAGraves/tg-clarify-find-docs
Clarifies the behavior of test renderer's find methods
2017-10-10 09:34:49 -07:00
Brian Vaughn
18000f1b37 Wording nit: s/the only/a single/ 2017-10-10 09:34:28 -07:00
Brian Vaughn
3b74f67bfd Merge pull request #105 from hozefaj/topic/fix-pure-comp-links
fix links to pure component within docs
2017-10-10 09:26:39 -07:00
Brian Vaughn
335085564e Merge pull request #101 from MaxHumme/patch-1
Clarify idea for improvement 1.
2017-10-10 09:11:03 -07:00
Brian Vaughn
0eb0110df9 Merge pull request #104 from jxom/create-script-for-checks-in-ci
Added fbjs eslint config, fixed lint errors and warnings
2017-10-10 08:42:58 -07:00
Dan Abramov
db1262d06f Tweak the event doc 2017-10-10 16:42:48 +01:00
Rodrigo Rosenfeld Rosas
ad8cb6ea70 Improve writing style in Reconciliation Tradeoffs (#119)
I've improved my previous changes to what re-render means by following Dan Abramov's
suggestion on the writing style to remove the parenthesis from that paragraph.

See issue #108 for more context.
2017-10-10 16:36:29 +01:00
Brian Vaughn
e9a67af470 Merge pull request #81 from sw-yx/documentArgsIssue75
added documentation for passing arguments to event handlers
2017-10-10 08:33:24 -07:00
Brian Vaughn
7f8d084a2c Wordsmithing 2017-10-10 08:33:00 -07:00
Brian Vaughn
3dfc414701 Nit 2017-10-10 08:32:29 -07:00
Brian Vaughn
57779b2fb3 Merge pull request #108 from rosenfeld/patch-1
Improves the documentation on Reconciliation
2017-10-10 08:20:09 -07:00
Brian Vaughn
348a727e8c Added parens 2017-10-10 08:19:29 -07:00
Max Humme
2ef21dfd4c Clarify idea for improvement 1.
When I was working through this, I found it not completely clear what was meant by 'instead of "6"'. I assumed the document refers to the move numbers in the move list, so that's what this change clarifies.
2017-10-10 15:02:25 +02:00
Fredrick Mgbeoma
a201113535 Added ellipsis to indicate incomplete code snippet (#115)
* Added ellipsis to indicate incomplete code snippet

Ellipsis indicate that the code snippet shown is part of a larger code sample.

* Add missing indentation
2017-10-10 12:51:41 +01:00
Dan Abramov
16b5b8f510 Tweak instructions 2017-10-10 11:54:43 +01:00
ishank
bad3d8853c Recommmended PureComponent instead of shallowCompare 2017-10-10 13:35:27 +05:30
jxom
4b155a22ed PR changes 2017-10-10 15:30:25 +11:00
sw-yx
037fdf82d0 modified handling-events page 2017-10-09 22:11:11 -04:00
Rodrigo Rosenfeld Rosas
b373eeccbd Improves the documentation on Reconciliation 2017-10-09 21:08:05 -03:00
Tommy Graves
192fca8a43 Clarifies the behavior of test renderer's find methods 2017-10-09 19:35:38 -04:00
hozefaj
43c1c00703 fix links to pure component within docs 2017-10-09 16:11:18 -07:00
jxom
de3bd87f4b Added fbjs eslint config, fixed lint errors and warnings 2017-10-10 08:41:44 +11:00
Brian Vaughn
8f50d04f92 Merge pull request #93 from jxom/create-script-for-checks-in-ci
Create script for checks (prettier, lint, flow) in CI
2017-10-09 14:35:06 -07:00
Brian Vaughn
580706b460 Merge pull request #55 from xjlim/style-props-value-px
add shorthand for specifying pixel values in style props to docs
2017-10-09 14:27:38 -07:00
Brian Vaughn
f3aea25776 Wording nits 2017-10-09 14:27:13 -07:00
jxom
5a96b1da03 Rename check-all:verbose to ci-check, add some useful eslint config 2017-10-10 08:22:12 +11:00
Brian Vaughn
43e971f5e9 Merge pull request #102 from MaxHumme/patch-2
Fix typo in idea for improvement 2.
2017-10-09 13:25:49 -07:00
Max Humme
8001445c8a Fix typo in idea for improvement 2.
Pretty sure "currently-selected" must be "currently selected".
2017-10-09 20:45:58 +02:00
Brian Vaughn
89cf6d20d6 Merge pull request #92 from damaera/fix-scroll
Fix scroll in CodeEditor
2017-10-09 08:58:42 -07:00
Brian Vaughn
58d57b9c33 Merge pull request #94 from zpao/spellfix
Correct spelling of ESLint
2017-10-09 08:50:28 -07:00
Brian Vaughn
d8d8f5da65 Merge pull request #90 from imagentleman/algolia-search-results-dropdown-border-artifact
Fix visible background over border radius in search dropdown
2017-10-09 08:42:56 -07:00
Paul O’Shannessy
6873c25c63 Correct spelling of ESLint 2017-10-09 12:04:02 +01:00
jxom
d26cf5f86c Add prettier:diff script 2017-10-09 21:04:29 +11:00
jxom
bbabe69bf2 Add script for check-all in CI 2017-10-09 20:58:52 +11:00
Damaera
b450b0d2c7 Fix scroll in CodeEditor, adding scroll in right panel. and adding padding bottom in code. #91 2017-10-09 14:23:41 +07:00
sw-yx
6dad6d2b7a added documentation for passing arguments to event handlers 2017-10-08 22:46:07 -04:00
Brian Vaughn
695e7905df Merge pull request #89 from dance2die/issue70
Add minimum required Node version to create-react-app docs #70
2017-10-08 19:01:01 -07:00
Brian Vaughn
5453a06528 Merge pull request #88 from jedwards1211/patch-1
Caution (in docs) against dispatching redux actions or triggering component updates by any other means in `componentWillUpdate`
2017-10-08 18:59:08 -07:00
imagentleman
06a8b8e0bb Fix visible background over border radius in search dropdown 2017-10-08 20:55:30 -05:00
Sung
ca0679478d Add minimum required Node version to create-react-app docs #70 2017-10-08 19:26:07 -04:00
Joe Lim
b333f92d76 fix minor formatting issue 2017-10-08 13:49:23 -07:00
Joe Lim
b0db2aad22 include notes on unitless props 2017-10-08 13:47:05 -07:00
Brian Vaughn
d5ebad1d2a Wordsmithing nit 2017-10-08 13:32:35 -07:00
Andy Edwards
e97ad4f5d4 Caution (in docs) against dispatching redux actions or triggering component updates by any other means in componentWillUpdate 2017-10-08 15:28:18 -05:00
Brian Vaughn
be1f9a60d8 Merge pull request #48 from jxom/update-sidebar-highlight-on-scroll
Tweak sidebar to update navigation highlight on scroll
2017-10-08 10:40:20 -07:00
Brian Vaughn
39def4b50c Removed no-longer-used isItemActive 2017-10-08 10:39:57 -07:00
Brian Vaughn
8a1c36e3f3 Merge pull request #63 from danielsbird/remove-duplicate-codepen-scripts
Load CodePen script once
2017-10-08 10:17:37 -07:00
Daniel Bird
37c9963889 Load CodePen script once 2017-10-07 22:49:34 -04:00