amirho/react.dev
1
0
Fork 0
mirror of https://github.com/reactjs/react.dev.git synced 2026-02-24 20:53:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

[Beta] Fix editor re-renders on lint error (#4699)

Browse Source
This commit is contained in:
dan
2022-05-26 18:37:10 +01:00
committed by GitHub
parent c209465d76
commit ee754727e2
1 changed files with 12 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
beta/src/components/MDX/Sandpack/Preview.tsx
View File

@@ -61,16 +61,23 @@ export function Preview({
rawError = null;
}
if (lintErrors.length > 0) {
if (rawError == null || rawError.title === 'Runtime Exception') {
// When there's a lint error, show it -- even over a runtime error.
// (However, when there's a build error, we keep showing the build one.)
// Memoized because it's fed to debouncing.
const firstLintError = React.useMemo(() => {
if (lintErrors.length === 0) {
return null;
} else {
const {line, column, message} = lintErrors[0];
rawError = {
return {
title: 'Lint Error',
message: `${line}:${column} - ${message}`,
};
}
}, [lintErrors]);
if (rawError == null || rawError.title === 'Runtime Exception') {
if (firstLintError !== null) {
rawError = firstLintError;
}
}
// It changes too fast, causing flicker.