amirho/react.dev
1
0
Fork 0
mirror of https://github.com/reactjs/react.dev.git synced 2026-02-23 20:23:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #49 from carloscuesta/docs-scu-deep-equality-json-stringify

Browse Source 
Document deepEquality checks & JSON.stringify in shouldComponentUpdate are a bad idea
This commit is contained in:
Brian Vaughn
2017-10-18 08:58:14 -07:00
committed by GitHub
parent ce4c050f8d 07b015b687
commit 8348250019
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
content/docs/reference-react-component.md
View File

@@ -212,6 +212,8 @@ Currently, if `shouldComponentUpdate()` returns `false`, then [`componentWillUpd
If you determine a specific component is slow after profiling, you may change it to inherit from [`React.PureComponent`](/docs/react-api.html#reactpurecomponent) which implements `shouldComponentUpdate()` with a shallow prop and state comparison. If you are confident you want to write it by hand, you may compare `this.props` with `nextProps` and `this.state` with `nextState` and return `false` to tell React the update can be skipped.
We do not recommend doing deep equality checks or using `JSON.stringify()` in `shouldComponentUpdate()`. It is very inefficient and will harm performance.
* * *
### `componentWillUpdate()`