amirho/express
1
0
Fork 0
mirror of https://github.com/expressjs/express.git synced 2026-02-21 19:41:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

tests: update res.append to verify separate header lines

Browse Source
This commit is contained in:
Douglas Christopher Wilson
2022-02-21 19:23:25 -05:00
parent 7df0c840e0
commit 9967ffbdc2
1 changed files with 41 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

71
test/res.append.js
View File

@@ -1,31 +1,29 @@
'use strict'
var assert = require('assert')
var express = require('..')
var request = require('supertest')
var should = require('should')
describe('res', function () {
// note about these tests: "Link" and "X-*" are chosen because
// the common node.js versions white list which _incoming_
// headers can appear multiple times; there is no such white list
// for outgoing, though
describe('.append(field, val)', function () {
it('should append multiple headers', function (done) {
var app = express()
app.use(function (req, res, next) {
res.append('Link', '<http://localhost/>')
res.append('Set-Cookie', 'foo=bar')
next()
})
app.use(function (req, res) {
res.append('Link', '<http://localhost:80/>')
res.append('Set-Cookie', 'fizz=buzz')
res.end()
})
request(app)
.get('/')
.expect('Link', '<http://localhost/>, <http://localhost:80/>', done)
.get('/')
.expect(200)
.expect(shouldHaveHeaderValues('Set-Cookie', ['foo=bar', 'fizz=buzz']))
.end(done)
})
it('should accept array of values', function (done) {
@@ -37,51 +35,54 @@ describe('res', function () {
})
request(app)
.get('/')
.expect(function (res) {
should(res.headers['set-cookie']).eql(['foo=bar', 'fizz=buzz'])
})
.expect(200, done)
.get('/')
.expect(200)
.expect(shouldHaveHeaderValues('Set-Cookie', ['foo=bar', 'fizz=buzz']))
.end(done)
})
it('should get reset by res.set(field, val)', function (done) {
var app = express()
app.use(function (req, res, next) {
res.append('Link', '<http://localhost/>')
res.append('Link', '<http://localhost:80/>')
res.append('Set-Cookie', 'foo=bar')
res.append('Set-Cookie', 'fizz=buzz')
next()
})
app.use(function (req, res) {
res.set('Link', '<http://127.0.0.1/>')
res.set('Set-Cookie', 'pet=tobi')
res.end()
});
request(app)
.get('/')
.expect('Link', '<http://127.0.0.1/>', done)
.get('/')
.expect(200)
.expect(shouldHaveHeaderValues('Set-Cookie', ['pet=tobi']))
.end(done)
})
it('should work with res.set(field, val) first', function (done) {
var app = express()
app.use(function (req, res, next) {
res.set('Link', '<http://localhost/>')
res.set('Set-Cookie', 'foo=bar')
next()
})
app.use(function(req, res){
res.append('Link', '<http://localhost:80/>')
res.append('Set-Cookie', 'fizz=buzz')
res.end()
})
request(app)
.get('/')
.expect('Link', '<http://localhost/>, <http://localhost:80/>', done)
.get('/')
.expect(200)
.expect(shouldHaveHeaderValues('Set-Cookie', ['foo=bar', 'fizz=buzz']))
.end(done)
})
it('should work with cookies', function (done) {
it('should work together with res.cookie', function (done) {
var app = express()
app.use(function (req, res, next) {
@@ -90,16 +91,26 @@ describe('res', function () {
})
app.use(function (req, res) {
res.append('Set-Cookie', 'bar=baz')
res.append('Set-Cookie', 'fizz=buzz')
res.end()
})
request(app)
.get('/')
.expect(function (res) {
should(res.headers['set-cookie']).eql(['foo=bar; Path=/', 'bar=baz'])
})
.expect(200, done)
.get('/')
.expect(200)
.expect(shouldHaveHeaderValues('Set-Cookie', ['foo=bar; Path=/', 'fizz=buzz']))
.end(done)
})
})
})
function shouldHaveHeaderValues (key, values) {
return function (res) {
var headers = res.headers[key.toLowerCase()]
assert.ok(headers, 'should have header "' + key + '"')
assert.strictEqual(headers.length, values.length, 'should have ' + values.length + ' occurances of "' + key + '"')
for (var i = 0; i < values.length; i++) {
assert.strictEqual(headers[i], values[i])
}
}
}