mirror of
https://github.com/facebook/react.git
synced 2026-02-27 03:07:57 +00:00
Randomly noticed this when I looked at a recent [DevTools regression test run](https://github.com/facebook/react/actions/runs/13578385011). I don't recall why we added `continue-on-error` previously, but I believe it was to keep all jobs in the matrix running even if one were to fail, in order to fully identify any failures from code changes like build or test failures. There is now a `fail-fast` option which does this. [`continue-on-error`](https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#jobsjob_idcontinue-on-error) now means: > Prevents a workflow run from failing when a job fails. Set to true to allow a workflow run to pass when this job fails. so it's not correct to use it.
179 lines
5.9 KiB
YAML
179 lines
5.9 KiB
YAML
name: (DevTools) Regression Tests
|
|
|
|
on:
|
|
schedule:
|
|
- cron: 0 0 * * *
|
|
workflow_dispatch:
|
|
inputs:
|
|
commit_sha:
|
|
required: false
|
|
type: string
|
|
|
|
env:
|
|
TZ: /usr/share/zoneinfo/America/Los_Angeles
|
|
# https://github.com/actions/cache/blob/main/tips-and-workarounds.md#cache-segment-restore-timeout
|
|
SEGMENT_DOWNLOAD_TIMEOUT_MINS: 1
|
|
|
|
jobs:
|
|
download_build:
|
|
name: Download base build
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@v4
|
|
- uses: actions/setup-node@v4
|
|
with:
|
|
node-version-file: '.nvmrc'
|
|
cache: yarn
|
|
cache-dependency-path: yarn.lock
|
|
- name: Restore cached node_modules
|
|
uses: actions/cache@v4
|
|
id: node_modules
|
|
with:
|
|
path: "**/node_modules"
|
|
key: runtime-release-node_modules-${{ runner.arch }}-${{ runner.os }}-${{ hashFiles('yarn.lock', 'scripts/release/yarn.lock') }}
|
|
- name: Ensure clean build directory
|
|
run: rm -rf build
|
|
- run: yarn install --frozen-lockfile
|
|
- run: yarn install --frozen-lockfile
|
|
working-directory: scripts/release
|
|
- name: Download react-devtools artifacts for base revision
|
|
run: |
|
|
git fetch origin main
|
|
GH_TOKEN=${{ github.token }} scripts/release/download-experimental-build.js --commit=${{ inputs.commit_sha || '$(git rev-parse origin/main)' }}
|
|
- name: Display structure of build
|
|
run: ls -R build
|
|
- name: Archive build
|
|
uses: actions/upload-artifact@v4
|
|
with:
|
|
name: build
|
|
path: build
|
|
|
|
build_devtools_and_process_artifacts:
|
|
name: Build DevTools and process artifacts
|
|
needs: download_build
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@v4
|
|
- uses: actions/setup-node@v4
|
|
with:
|
|
node-version-file: '.nvmrc'
|
|
cache: yarn
|
|
cache-dependency-path: yarn.lock
|
|
- name: Restore cached node_modules
|
|
uses: actions/cache@v4
|
|
id: node_modules
|
|
with:
|
|
path: "**/node_modules"
|
|
key: runtime-node_modules-${{ runner.arch }}-${{ runner.os }}-${{ hashFiles('yarn.lock') }}
|
|
- name: Ensure clean build directory
|
|
run: rm -rf build
|
|
- run: yarn install --frozen-lockfile
|
|
- name: Restore archived build
|
|
uses: actions/download-artifact@v4
|
|
with:
|
|
name: build
|
|
path: build
|
|
- run: ./scripts/ci/pack_and_store_devtools_artifacts.sh
|
|
env:
|
|
RELEASE_CHANNEL: experimental
|
|
- name: Display structure of build
|
|
run: ls -R build
|
|
- name: Archive devtools build
|
|
uses: actions/upload-artifact@v4
|
|
with:
|
|
name: react-devtools
|
|
path: build/devtools.tgz
|
|
# Simplifies getting the extension for local testing
|
|
- name: Archive chrome extension
|
|
uses: actions/upload-artifact@v4
|
|
with:
|
|
name: react-devtools-chrome-extension
|
|
path: build/devtools/chrome-extension.zip
|
|
- name: Archive firefox extension
|
|
uses: actions/upload-artifact@v4
|
|
with:
|
|
name: react-devtools-firefox-extension
|
|
path: build/devtools/firefox-extension.zip
|
|
|
|
run_devtools_tests_for_versions:
|
|
name: Run DevTools tests for versions
|
|
needs: build_devtools_and_process_artifacts
|
|
runs-on: ubuntu-latest
|
|
strategy:
|
|
fail-fast: false
|
|
matrix:
|
|
version:
|
|
- "16.0"
|
|
- "16.5" # schedule package
|
|
- "16.8" # hooks
|
|
- "17.0"
|
|
- "18.0"
|
|
- "18.2" # compiler polyfill
|
|
steps:
|
|
- uses: actions/checkout@v4
|
|
- uses: actions/setup-node@v4
|
|
with:
|
|
node-version-file: '.nvmrc'
|
|
cache: yarn
|
|
cache-dependency-path: yarn.lock
|
|
- name: Restore cached node_modules
|
|
uses: actions/cache@v4
|
|
id: node_modules
|
|
with:
|
|
path: "**/node_modules"
|
|
key: runtime-node_modules-${{ runner.arch }}-${{ runner.os }}-${{ hashFiles('yarn.lock') }}
|
|
- run: yarn install --frozen-lockfile
|
|
- name: Restore all archived build artifacts
|
|
uses: actions/download-artifact@v4
|
|
- name: Display structure of build
|
|
run: ls -R build
|
|
- run: ./scripts/ci/download_devtools_regression_build.js ${{ matrix.version }} --replaceBuild
|
|
- run: node ./scripts/jest/jest-cli.js --build --project devtools --release-channel=experimental --reactVersion ${{ matrix.version }} --ci
|
|
|
|
run_devtools_e2e_tests_for_versions:
|
|
name: Run DevTools e2e tests for versions
|
|
needs: build_devtools_and_process_artifacts
|
|
runs-on: ubuntu-latest
|
|
strategy:
|
|
fail-fast: false
|
|
matrix:
|
|
version:
|
|
- "16.0"
|
|
- "16.5" # schedule package
|
|
- "16.8" # hooks
|
|
- "17.0"
|
|
- "18.0"
|
|
steps:
|
|
- uses: actions/checkout@v4
|
|
- uses: actions/setup-node@v4
|
|
with:
|
|
node-version-file: '.nvmrc'
|
|
cache: yarn
|
|
cache-dependency-path: yarn.lock
|
|
- name: Restore cached node_modules
|
|
uses: actions/cache@v4
|
|
id: node_modules
|
|
with:
|
|
path: "**/node_modules"
|
|
key: runtime-node_modules-${{ runner.arch }}-${{ runner.os }}-${{ hashFiles('yarn.lock') }}
|
|
- run: yarn install --frozen-lockfile
|
|
- name: Restore all archived build artifacts
|
|
uses: actions/download-artifact@v4
|
|
- name: Display structure of build
|
|
run: ls -R build
|
|
- name: Playwright install deps
|
|
run: |
|
|
npx playwright install
|
|
sudo npx playwright install-deps
|
|
- run: ./scripts/ci/download_devtools_regression_build.js ${{ matrix.version }}
|
|
- run: ls -R build-regression
|
|
- run: ./scripts/ci/run_devtools_e2e_tests.js ${{ matrix.version }}
|
|
env:
|
|
RELEASE_CHANNEL: experimental
|
|
- name: Cleanup build regression folder
|
|
run: rm -r ./build-regression
|
|
- uses: actions/upload-artifact@v4
|
|
with:
|
|
name: screenshots
|
|
path: ./tmp/screenshots
|