mirror of
https://github.com/facebook/react.git
synced 2026-02-24 20:53:03 +00:00
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory. Before submitting a pull request, please make sure the following is done: 1. Fork [the repository](https://github.com/facebook/react) and create your branch from `main`. 2. Run `yarn` in the repository root. 3. If you've fixed a bug or added code that should be tested, add tests! 4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development. 5. Run `yarn test --prod` to test in the production environment. It supports the same options as `yarn test`. 6. If you need a debugger, run `yarn test --debug --watch TestName`, open `chrome://inspect`, and press "Inspect". 7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`). 8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files. 9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`). 10. If you haven't already, complete the CLA. Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html --> ## Summary Fix how devtools handles URLs. It - cannot handle relative source map URLs `//# sourceMappingURL=x.map` - cannot recognize Windows style URLs ## How did you test this change? works on my side
128 lines
3.9 KiB
JavaScript
128 lines
3.9 KiB
JavaScript
/**
|
|
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*
|
|
* @flow
|
|
*/
|
|
|
|
import {normalizeUrl} from 'react-devtools-shared/src/utils';
|
|
import SourceMapConsumer from 'react-devtools-shared/src/hooks/SourceMapConsumer';
|
|
|
|
import type {Source} from 'react-devtools-shared/src/shared/types';
|
|
import type {FetchFileWithCaching} from 'react-devtools-shared/src/devtools/views/Components/FetchFileWithCachingContext';
|
|
|
|
const symbolicationCache: Map<string, Promise<Source | null>> = new Map();
|
|
|
|
export async function symbolicateSourceWithCache(
|
|
fetchFileWithCaching: FetchFileWithCaching,
|
|
sourceURL: string,
|
|
line: number, // 1-based
|
|
column: number, // 1-based
|
|
): Promise<Source | null> {
|
|
const key = `${sourceURL}:${line}:${column}`;
|
|
const cachedPromise = symbolicationCache.get(key);
|
|
if (cachedPromise != null) {
|
|
return cachedPromise;
|
|
}
|
|
|
|
const promise = symbolicateSource(
|
|
fetchFileWithCaching,
|
|
sourceURL,
|
|
line,
|
|
column,
|
|
);
|
|
symbolicationCache.set(key, promise);
|
|
|
|
return promise;
|
|
}
|
|
|
|
const SOURCE_MAP_ANNOTATION_PREFIX = 'sourceMappingURL=';
|
|
export async function symbolicateSource(
|
|
fetchFileWithCaching: FetchFileWithCaching,
|
|
sourceURL: string,
|
|
lineNumber: number, // 1-based
|
|
columnNumber: number, // 1-based
|
|
): Promise<Source | null> {
|
|
const resource = await fetchFileWithCaching(sourceURL).catch(() => null);
|
|
if (resource == null) {
|
|
return null;
|
|
}
|
|
|
|
const resourceLines = resource.split(/[\r\n]+/);
|
|
for (let i = resourceLines.length - 1; i >= 0; --i) {
|
|
const resourceLine = resourceLines[i];
|
|
|
|
// In case there is empty last line
|
|
if (!resourceLine) continue;
|
|
// Not an annotation? Stop looking for a source mapping url.
|
|
if (!resourceLine.startsWith('//#')) break;
|
|
|
|
if (resourceLine.includes(SOURCE_MAP_ANNOTATION_PREFIX)) {
|
|
const sourceMapAnnotationStartIndex = resourceLine.indexOf(
|
|
SOURCE_MAP_ANNOTATION_PREFIX,
|
|
);
|
|
const sourceMapAt = resourceLine.slice(
|
|
sourceMapAnnotationStartIndex + SOURCE_MAP_ANNOTATION_PREFIX.length,
|
|
resourceLine.length,
|
|
);
|
|
|
|
const sourceMapURL = new URL(sourceMapAt, sourceURL).toString();
|
|
const sourceMap = await fetchFileWithCaching(sourceMapURL).catch(
|
|
() => null,
|
|
);
|
|
if (sourceMap != null) {
|
|
try {
|
|
const parsedSourceMap = JSON.parse(sourceMap);
|
|
const consumer = SourceMapConsumer(parsedSourceMap);
|
|
const {
|
|
sourceURL: possiblyURL,
|
|
line,
|
|
column,
|
|
} = consumer.originalPositionFor({
|
|
lineNumber, // 1-based
|
|
columnNumber, // 1-based
|
|
});
|
|
|
|
if (possiblyURL === null) {
|
|
return null;
|
|
}
|
|
try {
|
|
// sourceMapURL = https://react.dev/script.js.map
|
|
void new URL(possiblyURL); // test if it is a valid URL
|
|
const normalizedURL = normalizeUrl(possiblyURL);
|
|
|
|
return {sourceURL: normalizedURL, line, column};
|
|
} catch (e) {
|
|
// This is not valid URL
|
|
if (
|
|
// sourceMapURL = /file
|
|
possiblyURL.startsWith('/') ||
|
|
// sourceMapURL = C:\\...
|
|
possiblyURL.slice(1).startsWith(':\\\\')
|
|
) {
|
|
// This is an absolute path
|
|
return {sourceURL: possiblyURL, line, column};
|
|
}
|
|
|
|
// This is a relative path
|
|
// possiblyURL = x.js.map, sourceMapURL = https://react.dev/script.js.map
|
|
const absoluteSourcePath = new URL(
|
|
possiblyURL,
|
|
sourceMapURL,
|
|
).toString();
|
|
return {sourceURL: absoluteSourcePath, line, column};
|
|
}
|
|
} catch (e) {
|
|
return null;
|
|
}
|
|
}
|
|
|
|
return null;
|
|
}
|
|
}
|
|
|
|
return null;
|
|
}
|