mirror of https://github.com/facebook/react.git synced 2026-02-26 18:58:05 +00:00

Files

Sebastian Markbåge d9e00f795b Stop flowing and then abort if a stream is cancelled (#27405 )

We currently abort a stream either it's explicitly told to abort (e.g.
by an abortsignal). In this case we still finish writing what we have as
well as instructions for the client about what happened so it can
trigger fallback cases and log appropriately.

We also abort a request if the stream itself cancels. E.g. if you can't
write anymore. In this case we should not write anything to the outgoing
stream since it's supposed to be closed already now. However, we should
still abort the request so that more work isn't performed and so that we
can log the reason for it to the onError callback.

We should also not do any work after aborting.

There we need to stop the "flow" of bytes - so I call stopFlowing in the
cancel case before aborting.

The tests were testing this case but we had changed the implementation
to only start flowing at initial read (pull) instead of start like we
used to. As a result, it was no longer covering this case. We have to
call reader.read() in the tests to start the flow so that we need to
cancel it.

We also were missing a final assertion on the error logs and since we
were tracking them explicitly the extra error was silenced.

2023-09-22 15:16:49 -04:00

npm

Remove Blocks (#20138 )

2020-10-30 23:03:45 -07:00

src

Stop flowing and then abort if a stream is cancelled (#27405 )

2023-09-22 15:16:49 -04:00

flight.js

[Codemod] Update copyright header to Meta (#25315 )

2022-10-18 11:19:24 -04:00

index.js

[Codemod] Update copyright header to Meta (#25315 )