mirror of https://github.com/facebook/react.git synced 2026-02-24 20:53:03 +00:00

Files

Andrew Clark d07921eeda Don't modify keyPath until right before recursive renderNode call (#27366 )

Currently, if a component suspends, the keyPath has already been
modified to include the identity of the component itself; the path is
set before the component body is called (akin to the begin phase in
Fiber). An accidental consequence is that when the promise resolves and
component is retried, the identity gets appended to the keyPath again,
leading to a duplicate node in the path.

To address this, we should only modify contexts after any code that may
suspend. For maximum safety, this should occur as late as possible:
right before the recursive renderNode call, before the children are
rendered.

I did not add a test yet because there's no feature that currently
observes it, but I do have tests in my other WIP PR for useFormState:
#27321

2023-09-12 21:27:23 -04:00

npm

Remove Blocks (#20138 )

2020-10-30 23:03:45 -07:00

src

Don't modify keyPath until right before recursive renderNode call (#27366 )

2023-09-12 21:27:23 -04:00

flight.js

[Codemod] Update copyright header to Meta (#25315 )

2022-10-18 11:19:24 -04:00

index.js

[Codemod] Update copyright header to Meta (#25315 )