mirror of
https://github.com/facebook/react.git
synced 2026-02-24 20:53:03 +00:00
75955bf1d7
* Remove "Invariant Violation" from dev errors
When I made the change to compile `invariant` to throw expressions, I
left a small runtime to set the error's `name` property to "Invariant
Violation" to maintain the existing behavior.
I think we can remove it. The argument for keeping it is to preserve
continuity in error logs, but this only affects development errors,
anyway: production error messages are replaced with error codes.
* Pass prod error messages directly to constructor
Updates the `invariant` transform to pass an error message string
directly to the Error constructor, instead of mutating the
message property.
Turns this code:
```js
invariant(condition, 'A %s message that contains %s', adj, noun);
```
into this:
```js
if (!condition) {
throw Error(
__DEV__
? `A ${adj} message that contains ${noun}`
: formatProdErrorMessage(ERR_CODE, adj, noun)
);
}
```
60 lines
2.1 KiB
JavaScript
60 lines
2.1 KiB
JavaScript
/**
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*
|
|
* @emails react-core
|
|
*/
|
|
'use strict';
|
|
|
|
let formatProdErrorMessage;
|
|
|
|
describe('ReactErrorProd', () => {
|
|
let globalErrorMock;
|
|
|
|
beforeEach(() => {
|
|
if (!__DEV__) {
|
|
// In production, our Jest environment overrides the global Error
|
|
// class in order to decode error messages automatically. However
|
|
// this is a single test where we actually *don't* want to decode
|
|
// them. So we assert that the OriginalError exists, and temporarily
|
|
// set the global Error object back to it.
|
|
globalErrorMock = global.Error;
|
|
global.Error = globalErrorMock.OriginalError;
|
|
expect(typeof global.Error).toBe('function');
|
|
}
|
|
jest.resetModules();
|
|
formatProdErrorMessage = require('shared/formatProdErrorMessage').default;
|
|
});
|
|
|
|
afterEach(() => {
|
|
if (!__DEV__) {
|
|
global.Error = globalErrorMock;
|
|
}
|
|
});
|
|
|
|
it('should throw with the correct number of `%s`s in the URL', () => {
|
|
expect(formatProdErrorMessage(124, 'foo', 'bar')).toEqual(
|
|
'Minified React error #124; visit ' +
|
|
'https://reactjs.org/docs/error-decoder.html?invariant=124&args[]=foo&args[]=bar' +
|
|
' for the full message or use the non-minified dev environment' +
|
|
' for full errors and additional helpful warnings.',
|
|
);
|
|
|
|
expect(formatProdErrorMessage(20)).toEqual(
|
|
'Minified React error #20; visit ' +
|
|
'https://reactjs.org/docs/error-decoder.html?invariant=20' +
|
|
' for the full message or use the non-minified dev environment' +
|
|
' for full errors and additional helpful warnings.',
|
|
);
|
|
|
|
expect(formatProdErrorMessage(77, '<div>', '&?bar')).toEqual(
|
|
'Minified React error #77; visit ' +
|
|
'https://reactjs.org/docs/error-decoder.html?invariant=77&args[]=%3Cdiv%3E&args[]=%26%3Fbar' +
|
|
' for the full message or use the non-minified dev environment' +
|
|
' for full errors and additional helpful warnings.',
|
|
);
|
|
});
|
|
});
|