mirror of
https://github.com/facebook/react.git
synced 2026-02-23 20:23:02 +00:00
e8c6362678
## Summary ESLint v10.0.0 was released on February 7, 2026. The current `peerDependencies` for `eslint-plugin-react-hooks` only allows up to `^9.0.0`, which causes peer dependency warnings when installing with ESLint v10. This PR: - Adds `^10.0.0` to the eslint peer dependency range - Adds `eslint-v10` to devDependencies for testing - Adds an `eslint-v10` e2e fixture (based on the existing `eslint-v9` fixture) ESLint v10's main breaking changes (removal of legacy eslintrc config, deprecated context methods) don't affect this plugin - flat config is already supported since v7.0.0, and the deprecated APIs already have fallbacks in place. ## How did you test this change? Ran the existing unit test suite: ``` cd packages/eslint-plugin-react-hooks && yarn test ``` All 5082 tests passed.
67 lines
2.0 KiB
YAML
67 lines
2.0 KiB
YAML
name: (Runtime) ESLint Plugin E2E
|
|
|
|
on:
|
|
push:
|
|
branches: [main]
|
|
pull_request:
|
|
paths-ignore:
|
|
- compiler/**
|
|
|
|
permissions: {}
|
|
|
|
concurrency:
|
|
group: ${{ github.workflow }}-${{ github.ref_name }}-${{ github.event.pull_request.number || github.run_id }}
|
|
cancel-in-progress: true
|
|
|
|
env:
|
|
TZ: /usr/share/zoneinfo/America/Los_Angeles
|
|
|
|
jobs:
|
|
# ----- TESTS -----
|
|
test:
|
|
name: ESLint v${{ matrix.eslint_major }}
|
|
runs-on: ubuntu-latest
|
|
strategy:
|
|
fail-fast: false
|
|
matrix:
|
|
eslint_major:
|
|
- "6"
|
|
- "7"
|
|
- "8"
|
|
- "9"
|
|
- "10"
|
|
steps:
|
|
- uses: actions/checkout@v4
|
|
with:
|
|
ref: ${{ github.event.pull_request.head.sha || github.sha }}
|
|
- uses: actions/setup-node@v4
|
|
with:
|
|
node-version-file: '.nvmrc'
|
|
cache: yarn
|
|
cache-dependency-path: |
|
|
yarn.lock
|
|
compiler/yarn.lock
|
|
- name: Restore cached node_modules
|
|
uses: actions/cache@v4
|
|
id: node_modules
|
|
with:
|
|
path: |
|
|
**/node_modules
|
|
key: runtime-and-compiler-eslint_e2e-node_modules-v6-${{ runner.arch }}-${{ runner.os }}-${{ hashFiles('yarn.lock', 'compiler/yarn.lock', 'fixtures/eslint-v*/yarn.lock') }}
|
|
- name: Ensure clean build directory
|
|
run: rm -rf build
|
|
- run: yarn install --frozen-lockfile
|
|
if: steps.node_modules.outputs.cache-hit != 'true'
|
|
- run: yarn --cwd compiler install --frozen-lockfile
|
|
if: steps.node_modules.outputs.cache-hit != 'true'
|
|
- name: Install fixture dependencies
|
|
working-directory: ./fixtures/eslint-v${{ matrix.eslint_major }}
|
|
run: yarn --frozen-lockfile
|
|
if: steps.node_modules.outputs.cache-hit != 'true'
|
|
- name: Build plugin
|
|
working-directory: fixtures/eslint-v${{ matrix.eslint_major }}
|
|
run: node build.mjs
|
|
- name: Run lint test
|
|
working-directory: ./fixtures/eslint-v${{ matrix.eslint_major }}
|
|
run: yarn lint
|