react

amirho/react

Fork 0

mirror of https://github.com/facebook/react.git synced 2026-02-27 03:07:57 +00:00

Commit Graph

Author	SHA1	Message	Date
Sophie Alpert	b98adb648a	Simplify CSS shorthand property warning (#14183 ) I figured out a simpler way to do #14181. It does allocate some but I think that's OK. Time complexity might even be better since we avoid the nested loops the old one had.	2018-11-09 16:56:51 -08:00
Sophie Alpert	8ae867e6b5	Warn about conflicting style values during updates (#14181 ) This is one of the most insidious quirks of React DOM that people run into. Now we warn when we think an update is dangerous. We still allow rendering `{background, backgroundSize}` with unchanging values, for example. But once you remove either one or change `background` (without changing `backgroundSize` at the same time), that's bad news. So we warn. Fixes #6348.	2018-11-09 15:21:47 -08:00

Author

SHA1

Message

Date

Sophie Alpert

b98adb648a

Simplify CSS shorthand property warning (#14183 )

I figured out a simpler way to do #14181. It does allocate some but I think that's OK. Time complexity might even be better since we avoid the nested loops the old one had.

2018-11-09 16:56:51 -08:00

Sophie Alpert

8ae867e6b5

Warn about conflicting style values during updates (#14181 )

This is one of the most insidious quirks of React DOM that people run into. Now we warn when we think an update is dangerous.

We still allow rendering `{background, backgroundSize}` with unchanging values, for example. But once you remove either one or change `background` (without changing `backgroundSize` at the same time), that's bad news. So we warn.

Fixes #6348.

2018-11-09 15:21:47 -08:00

2 Commits