From fa5adb3bc44fae7ee97ad089f3e290be7153ed07 Mon Sep 17 00:00:00 2001 From: Brian Vaughn Date: Fri, 20 Oct 2017 08:53:15 -0700 Subject: [PATCH] Release script no longer auto-updates peerDependencies react version (#11292) * Release script ensures peer dep matches release major version, but otherwise no longer auto-updates them to exactly match the release version. * f --- .../release/build-commands/update-package-versions.js | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/scripts/release/build-commands/update-package-versions.js b/scripts/release/build-commands/update-package-versions.js index 5ed34f2fab..84b0212e82 100644 --- a/scripts/release/build-commands/update-package-versions.js +++ b/scripts/release/build-commands/update-package-versions.js @@ -42,8 +42,15 @@ const update = async ({cwd, dry, version}) => { } if (project !== 'react') { - json.peerDependencies.react = `^${version}`; + const peerVersion = json.peerDependencies.react.replace('^', ''); + + // Release engineers can manually update minor and bugfix versions, + // But we should ensure that major versions always match. + if (semver.major(version) !== semver.major(peerVersion)) { + json.peerDependencies.react = `^${semver.major(version)}.0.0`; + } } + await writeJson(path, json, {spaces: 2}); }; await Promise.all(projects.map(updateProjectPackage));