amirho/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2026-02-22 03:42:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

[Fiber] getNearestMountedFiber should consider fibers with alternates as mounted (#35578)

Browse Source
This commit is contained in:
Sebastian Markbåge
2026-01-21 08:33:35 -05:00
committed by GitHub
parent 7fccd6b5a3
commit b546603bcb
1 changed files with 17 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
packages/react-reconciler/src/ReactFiberTreeReflection.js vendored
View File

@@ -33,25 +33,24 @@ import {NoFlags, Placement, Hydrating} from './ReactFiberFlags';
export function getNearestMountedFiber(fiber: Fiber): null | Fiber { export function getNearestMountedFiber(fiber: Fiber): null | Fiber {
let node = fiber; let node = fiber;
let nearestMounted: null | Fiber = fiber; let nearestMounted: null | Fiber = fiber;
if (!fiber.alternate) { // If there is no alternate, this might be a new tree that isn't inserted
// If there is no alternate, this might be a new tree that isn't inserted // yet. If it is, then it will have a pending insertion effect on it.
// yet. If it is, then it will have a pending insertion effect on it. let nextNode: Fiber = node;
let nextNode: Fiber = node; while (nextNode && !nextNode.alternate) {
do { node = nextNode;
node = nextNode; if ((node.flags & (Placement | Hydrating)) !== NoFlags) {
if ((node.flags & (Placement | Hydrating)) !== NoFlags) { // This is an insertion or in-progress hydration. The nearest possible
// This is an insertion or in-progress hydration. The nearest possible // mounted fiber is the parent but we need to continue to figure out
// mounted fiber is the parent but we need to continue to figure out // if that one is still mounted.
// if that one is still mounted. nearestMounted = node.return;
nearestMounted = node.return;
}
// $FlowFixMe[incompatible-type] we bail out when we get a null
nextNode = node.return;
} while (nextNode);
} else {
while (node.return) {
node = node.return;
} }
// $FlowFixMe[incompatible-type] we bail out when we get a null
nextNode = node.return;
}
// After we've reached an alternate, go the rest of the way to see if the
// tree is still mounted. If it's not, its return pointer will be disconnected.
while (node.return) {
node = node.return;
} }
if (node.tag === HostRoot) { if (node.tag === HostRoot) {
// TODO: Check if this was a nested HostRoot when used with // TODO: Check if this was a nested HostRoot when used with