From 75dd053b5e83e8ae20e9f771bca7b95dba4ff881 Mon Sep 17 00:00:00 2001 From: Jan Kassens Date: Mon, 14 Oct 2024 10:13:40 -0400 Subject: [PATCH] [string-refs] make disableStringRefs a dynamic www flag (#31175) --- packages/shared/forks/ReactFeatureFlags.www-dynamic.js | 1 + packages/shared/forks/ReactFeatureFlags.www.js | 5 +---- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/packages/shared/forks/ReactFeatureFlags.www-dynamic.js b/packages/shared/forks/ReactFeatureFlags.www-dynamic.js index 3888339bff..d4102efb06 100644 --- a/packages/shared/forks/ReactFeatureFlags.www-dynamic.js +++ b/packages/shared/forks/ReactFeatureFlags.www-dynamic.js @@ -18,6 +18,7 @@ export const disableDefaultPropsExceptForClasses = __VARIANT__; export const disableLegacyContextForFunctionComponents = __VARIANT__; export const disableLegacyMode = __VARIANT__; export const disableSchedulerTimeoutInWorkLoop = __VARIANT__; +export const disableStringRefs = __VARIANT__; export const enableDeferRootSchedulingToMicrotask = __VARIANT__; export const enableDO_NOT_USE_disableStrictPassiveEffect = __VARIANT__; export const enableHiddenSubtreeInsertionEffectCleanup = __VARIANT__; diff --git a/packages/shared/forks/ReactFeatureFlags.www.js b/packages/shared/forks/ReactFeatureFlags.www.js index 7484832a68..ec572d86f5 100644 --- a/packages/shared/forks/ReactFeatureFlags.www.js +++ b/packages/shared/forks/ReactFeatureFlags.www.js @@ -19,6 +19,7 @@ export const { disableDefaultPropsExceptForClasses, disableLegacyContextForFunctionComponents, disableSchedulerTimeoutInWorkLoop, + disableStringRefs, enableDebugTracing, enableDeferRootSchedulingToMicrotask, enableDO_NOT_USE_disableStrictPassiveEffect, @@ -120,10 +121,6 @@ export const enableServerComponentLogs = true; export const enableReactTestRendererWarning = false; export const useModernStrictMode = true; -// TODO: Roll out with GK. Don't keep as dynamic flag for too long, though, -// because JSX is an extremely hot path. -export const disableStringRefs = false; - export const disableLegacyMode: boolean = __EXPERIMENTAL__ || dynamicFeatureFlags.disableLegacyMode;