From 346350f77d2aa73ee7b93edbee2c2b3a4afddfab Mon Sep 17 00:00:00 2001 From: Mofei Zhang Date: Tue, 5 Dec 2023 17:22:37 -0500 Subject: [PATCH] Revert: revert tsconfig module change for rollup --- Currently on main, rollup does not inline source files ```js // in packages/babel-plugin-react-forget // $yarn build // output var CompilerError_1 = require("./CompilerError"); Object.defineProperty(exports, "CompilerError", { enumerable: true, get: function () { return CompilerError_1.CompilerError; } }); // ... ``` I debugged a bit but not familiar with node or rollup. - It seems that rollup fails to recognize source file imports with this setting, as resolveId no longer gets called - current `module` option defaults to `ESNext`, which works for some reason. Let's revert for now to unblock syncs. Sanity checked my repro by reinstalling node-modules and cleaning rollup cache. --- compiler/packages/babel-plugin-react-forget/tsconfig.json | 1 - 1 file changed, 1 deletion(-) diff --git a/compiler/packages/babel-plugin-react-forget/tsconfig.json b/compiler/packages/babel-plugin-react-forget/tsconfig.json index 7ad9ed7ac7..2050026aa4 100644 --- a/compiler/packages/babel-plugin-react-forget/tsconfig.json +++ b/compiler/packages/babel-plugin-react-forget/tsconfig.json @@ -1,7 +1,6 @@ { "extends": "@tsconfig/node18-strictest/tsconfig.json", "compilerOptions": { - "module": "NodeNext", "moduleResolution": "NodeNext", "declaration": true, "declarationDir": "./dist",