From 0e5767824f4c1122e94de61b0392a6942df642ab Mon Sep 17 00:00:00 2001
From: Dan Abramov <dan.abramov@gmail.com>
Date: Tue, 17 Oct 2017 20:53:15 +0100
Subject: [PATCH] Don't mark portals for updates (#11255)

---
 src/renderers/shared/fiber/ReactFiberCommitWork.js         | 7 -------
 src/renderers/shared/fiber/ReactFiberCompleteWork.js       | 2 --
 .../__snapshots__/ReactIncrementalPerf-test.js.snap        | 4 ++--
 3 files changed, 2 insertions(+), 11 deletions(-)

diff --git a/src/renderers/shared/fiber/ReactFiberCommitWork.js b/src/renderers/shared/fiber/ReactFiberCommitWork.js
index a6edb69939..1cf90d93e3 100644
--- a/src/renderers/shared/fiber/ReactFiberCommitWork.js
+++ b/src/renderers/shared/fiber/ReactFiberCommitWork.js
@@ -162,10 +162,6 @@ module.exports = function<T, P, I, TI, PI, C, CX, PL>(
         // We have no life-cycles associated with text.
         return;
       }
-      case HostPortal: {
-        // We have no life-cycles associated with portals.
-        return;
-      }
       default: {
         invariant(
           false,
@@ -589,9 +585,6 @@ module.exports = function<T, P, I, TI, PI, C, CX, PL>(
       case HostRoot: {
         return;
       }
-      case HostPortal: {
-        return;
-      }
       default: {
         invariant(
           false,
diff --git a/src/renderers/shared/fiber/ReactFiberCompleteWork.js b/src/renderers/shared/fiber/ReactFiberCompleteWork.js
index edb6048e91..afc3b5d52b 100644
--- a/src/renderers/shared/fiber/ReactFiberCompleteWork.js
+++ b/src/renderers/shared/fiber/ReactFiberCompleteWork.js
@@ -372,8 +372,6 @@ module.exports = function<T, P, I, TI, PI, C, CX, PL>(
       case Fragment:
         return null;
       case HostPortal:
-        // TODO: Only mark this as an update if we have any pending callbacks.
-        markUpdate(workInProgress);
         popHostContainer(workInProgress);
         return null;
       // Error cases
diff --git a/src/renderers/shared/fiber/__tests__/__snapshots__/ReactIncrementalPerf-test.js.snap b/src/renderers/shared/fiber/__tests__/__snapshots__/ReactIncrementalPerf-test.js.snap
index 2d7df86c0a..2e7dcb5371 100644
--- a/src/renderers/shared/fiber/__tests__/__snapshots__/ReactIncrementalPerf-test.js.snap
+++ b/src/renderers/shared/fiber/__tests__/__snapshots__/ReactIncrementalPerf-test.js.snap
@@ -237,8 +237,8 @@ exports[`ReactDebugFiberPerf supports portals 1`] = `
   ⚛ Parent [mount]
     ⚛ Child [mount]
   ⚛ (Committing Changes)
-    ⚛ (Committing Host Effects: 3 Total)
-    ⚛ (Calling Lifecycle Methods: 1 Total)
+    ⚛ (Committing Host Effects: 2 Total)
+    ⚛ (Calling Lifecycle Methods: 0 Total)
 "
 `;