From 2255e1efed752e849c0a2fb2533a178bef7dd821 Mon Sep 17 00:00:00 2001 From: Anna Do Date: Mon, 9 Oct 2017 19:11:04 -0400 Subject: [PATCH 1/3] Added a note that mockComponent is legacy and unnecessary --- content/docs/addons-test-utils.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/content/docs/addons-test-utils.md b/content/docs/addons-test-utils.md index fc482e19f..3e43023f1 100644 --- a/content/docs/addons-test-utils.md +++ b/content/docs/addons-test-utils.md @@ -112,6 +112,10 @@ mockComponent( Pass a mocked component module to this method to augment it with useful methods that allow it to be used as a dummy React component. Instead of rendering as usual, the component will become a simple `
` (or other tag if `mockTagName` is provided) containing any provided children. +> Note: +> +> `mockComponent()` is a legacy method that is no longer needed. A similar method can be implemented directly. + * * * ### `isElement()` From 592c3838b8c3ff5758e4d302d8ef07bccb8115bc Mon Sep 17 00:00:00 2001 From: Anna Do Date: Mon, 9 Oct 2017 19:17:57 -0400 Subject: [PATCH 2/3] Noted that a similar pattern can be implemented directly --- content/docs/addons-test-utils.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/docs/addons-test-utils.md b/content/docs/addons-test-utils.md index 3e43023f1..7552a1d93 100644 --- a/content/docs/addons-test-utils.md +++ b/content/docs/addons-test-utils.md @@ -114,7 +114,7 @@ Pass a mocked component module to this method to augment it with useful methods > Note: > -> `mockComponent()` is a legacy method that is no longer needed. A similar method can be implemented directly. +> `mockComponent()` is a legacy method that is no longer needed. A similar pattern can be implemented directly. * * * From b6e2f24421e2ef99da3a017081c50b69d8c02455 Mon Sep 17 00:00:00 2001 From: Anna Do Date: Tue, 10 Oct 2017 13:42:07 -0400 Subject: [PATCH 3/3] Added recommendation to use shallow rendering or jest.mock() --- content/docs/addons-test-utils.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/docs/addons-test-utils.md b/content/docs/addons-test-utils.md index 7552a1d93..cabf7bc3f 100644 --- a/content/docs/addons-test-utils.md +++ b/content/docs/addons-test-utils.md @@ -114,7 +114,7 @@ Pass a mocked component module to this method to augment it with useful methods > Note: > -> `mockComponent()` is a legacy method that is no longer needed. A similar pattern can be implemented directly. +> `mockComponent()` is a legacy API. We recommend using [shallow rendering](/docs/test-utils.html#shallow-rendering) or [jest.mock()](https://facebook.github.io/jest/docs/en/tutorial-react-native.html#mock-native-modules-using-jestmock) instead. * * *