amirho/nest
1
0
Fork 0
mirror of https://github.com/nestjs/nest.git synced 2026-02-21 23:11:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(core): make sure lifecycle hooks are not functions

Browse Source
This commit is contained in:
Kamil Myśliwiec
2021-11-16 10:13:13 +01:00
parent 0be499087f
commit c8bd6a9e51
5 changed files with 12 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/core/hooks/before-app-shutdown.hook.ts
View File

@@ -1,5 +1,5 @@
import { BeforeApplicationShutdown } from '@nestjs/common'; import { BeforeApplicationShutdown } from '@nestjs/common';
import { isNil } from '@nestjs/common/utils/shared.utils'; import { isFunction, isNil } from '@nestjs/common/utils/shared.utils';
import { iterate } from 'iterare'; import { iterate } from 'iterare';
import { import {
getNonTransientInstances, getNonTransientInstances,
@@ -16,7 +16,7 @@ import { Module } from '../injector/module';
function hasBeforeApplicationShutdownHook( function hasBeforeApplicationShutdownHook(
instance: unknown, instance: unknown,
): instance is BeforeApplicationShutdown { ): instance is BeforeApplicationShutdown {
return !isNil( return isFunction(
(instance as BeforeApplicationShutdown).beforeApplicationShutdown, (instance as BeforeApplicationShutdown).beforeApplicationShutdown,
); );
} }

6
packages/core/hooks/on-app-bootstrap.hook.ts
View File

@@ -1,5 +1,5 @@
import { OnApplicationBootstrap } from '@nestjs/common'; import { OnApplicationBootstrap } from '@nestjs/common';
import { isNil } from '@nestjs/common/utils/shared.utils'; import { isFunction, isNil } from '@nestjs/common/utils/shared.utils';
import { iterate } from 'iterare'; import { iterate } from 'iterare';
import { import {
getNonTransientInstances, getNonTransientInstances,
@@ -16,7 +16,9 @@ import { Module } from '../injector/module';
function hasOnAppBootstrapHook( function hasOnAppBootstrapHook(
instance: unknown, instance: unknown,
): instance is OnApplicationBootstrap { ): instance is OnApplicationBootstrap {
return !isNil((instance as OnApplicationBootstrap).onApplicationBootstrap); return isFunction(
(instance as OnApplicationBootstrap).onApplicationBootstrap,
);
} }
/** /**

4
packages/core/hooks/on-app-shutdown.hook.ts
View File

@@ -1,5 +1,5 @@
import { OnApplicationShutdown } from '@nestjs/common'; import { OnApplicationShutdown } from '@nestjs/common';
import { isNil } from '@nestjs/common/utils/shared.utils'; import { isFunction, isNil } from '@nestjs/common/utils/shared.utils';
import { iterate } from 'iterare'; import { iterate } from 'iterare';
import { import {
getNonTransientInstances, getNonTransientInstances,
@@ -16,7 +16,7 @@ import { Module } from '../injector/module';
function hasOnAppShutdownHook( function hasOnAppShutdownHook(
instance: unknown, instance: unknown,
): instance is OnApplicationShutdown { ): instance is OnApplicationShutdown {
return !isNil((instance as OnApplicationShutdown).onApplicationShutdown); return isFunction((instance as OnApplicationShutdown).onApplicationShutdown);
} }
/** /**

4
packages/core/hooks/on-module-destroy.hook.ts
View File

@@ -1,5 +1,5 @@
import { OnModuleDestroy } from '@nestjs/common'; import { OnModuleDestroy } from '@nestjs/common';
import { isNil } from '@nestjs/common/utils/shared.utils'; import { isFunction, isNil } from '@nestjs/common/utils/shared.utils';
import { iterate } from 'iterare'; import { iterate } from 'iterare';
import { import {
getNonTransientInstances, getNonTransientInstances,
@@ -16,7 +16,7 @@ import { Module } from '../injector/module';
function hasOnModuleDestroyHook( function hasOnModuleDestroyHook(
instance: unknown, instance: unknown,
): instance is OnModuleDestroy { ): instance is OnModuleDestroy {
return !isNil((instance as OnModuleDestroy).onModuleDestroy); return isFunction((instance as OnModuleDestroy).onModuleDestroy);
} }
/** /**

4
packages/core/hooks/on-module-init.hook.ts
View File

@@ -1,5 +1,5 @@
import { OnModuleInit } from '@nestjs/common'; import { OnModuleInit } from '@nestjs/common';
import { isNil } from '@nestjs/common/utils/shared.utils'; import { isFunction, isNil } from '@nestjs/common/utils/shared.utils';
import { iterate } from 'iterare'; import { iterate } from 'iterare';
import { import {
getNonTransientInstances, getNonTransientInstances,
@@ -14,7 +14,7 @@ import { Module } from '../injector/module';
* @param instance The instance which should be checked * @param instance The instance which should be checked
*/ */
function hasOnModuleInitHook(instance: unknown): instance is OnModuleInit { function hasOnModuleInitHook(instance: unknown): instance is OnModuleInit {
return !isNil((instance as OnModuleInit).onModuleInit); return isFunction((instance as OnModuleInit).onModuleInit);
} }
/** /**