amirho/nest
1
0
Fork 0
mirror of https://github.com/nestjs/nest.git synced 2026-02-21 23:11:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #12974 from toxol/rmq-nack-when-no-message-handler

Browse Source 
fix(microservices): send rmq nack without matching message handler
This commit is contained in:
Kamil Mysliwiec
2024-02-07 09:54:01 +01:00
committed by GitHub
parent f477d5bc0f e43df5ad44
commit a58f6a9cb4
3 changed files with 37 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
packages/microservices/constants.ts
View File

@@ -44,7 +44,12 @@ export const RQM_NO_EVENT_HANDLER = (
text: TemplateStringsArray,
pattern: string,
) =>
`An unsupported event was received. It has been acknowledged, so it will not be re-delivered. Pattern: ${pattern}`;
`An unsupported event was received. It has been negative acknowledged, so it will not be re-delivered. Pattern: ${pattern}`;
export const RQM_NO_MESSAGE_HANDLER = (
text: TemplateStringsArray,
pattern: string,
) =>
`An unsupported message was received. It has been negative acknowledged, so it will not be re-delivered. Pattern: ${pattern}`;
export const GRPC_DEFAULT_PROTO_LOADER = '@grpc/proto-loader';
export const NO_EVENT_HANDLER = (text: TemplateStringsArray, pattern: string) =>

5
packages/microservices/server/server-rmq.ts
View File

@@ -18,6 +18,7 @@ import {
RQM_DEFAULT_QUEUE_OPTIONS,
RQM_DEFAULT_URL,
RQM_NO_EVENT_HANDLER,
RQM_NO_MESSAGE_HANDLER,
} from '../constants';
import { RmqContext } from '../ctx-host';
import { Transport } from '../enums';
@@ -184,6 +185,10 @@ export class ServerRMQ extends Server implements CustomTransportStrategy {
const handler = this.getHandlerByPattern(pattern);
if (!handler) {
if (!this.noAck) {
this.logger.warn(RQM_NO_MESSAGE_HANDLER`${pattern}`);
this.channel.nack(rmqContext.getMessage(), false, false);
}
const status = 'error';
const noHandlerPacket = {
id: (packet as IncomingRequest).id,

26
packages/microservices/test/server/server-rmq.spec.ts
View File

@@ -110,6 +110,9 @@ describe('ServerRMQ', () => {
sendMessageStub = sinon.stub(server, 'sendMessage').callsFake(() => ({}));
(server as any).channel = channel;
});
afterEach(() => {
channel.nack.resetHistory();
});
it('should call "handleEvent" if identifier is not present', async () => {
const handleEventSpy = sinon.spy(server, 'handleEvent');
await server.handleMessage(createMessage({ pattern: '', data: '' }), '');
@@ -149,6 +152,29 @@ describe('ServerRMQ', () => {
assert.fail('Was not supposed to throw an error');
});
});
it('should negative acknowledge if message does not exists in handlers object and noAck option is false', async () => {
(server as any).noAck = false;
await server.handleMessage(msg, '');
expect(channel.nack.calledWith(msg, false, false)).to.be.true;
expect(
sendMessageStub.calledWith({
id: '3',
status: 'error',
err: NO_MESSAGE_HANDLER,
}),
).to.be.true;
});
it('should not negative acknowledge if key does not exists in handlers object and noAck option is true', async () => {
await server.handleMessage(msg, '');
expect(channel.nack.notCalled).to.be.true;
expect(
sendMessageStub.calledWith({
id: '3',
status: 'error',
err: NO_MESSAGE_HANDLER,
}),
).to.be.true;
});
});
describe('setupChannel', () => {
const queue = 'test';