amirho/nest
1
0
Fork 0
mirror of https://github.com/nestjs/nest.git synced 2026-02-21 23:11:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: methods order, types in e2e test

Browse Source
This commit is contained in:
Kamil Myśliwiec
2024-11-25 14:34:28 +01:00
parent 95c8547b68
commit 84b8744f90
2 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
integration/websockets/e2e/gateway.spec.ts
View File

@@ -17,7 +17,7 @@ async function createNestApp(...gateways): Promise<INestApplication> {
}
describe('WebSocketGateway', () => {
let ws, app;
let ws: ReturnType<typeof io>, app: INestApplication;
it(`should handle message (2nd port)`, async () => {
app = await createNestApp(ApplicationGateway);
@@ -100,7 +100,7 @@ describe('WebSocketGateway', () => {
);
});
describe('Shared Server for WebSocket and Long-Running Connections', () => {
describe('shared server for WS and Long-Running connections', () => {
afterEach(() => {});
it('should block application shutdown', function (done) {
let eventSource;
@@ -126,7 +126,7 @@ describe('WebSocketGateway', () => {
ws = io(`http://localhost:3000`);
eventSource = new EventSource(`http://localhost:3000/sse`);
await new Promise((resolve, reject) => {
await new Promise<void>((resolve, reject) => {
ws.on('connect', resolve);
ws.on('error', reject);
});
@@ -155,7 +155,7 @@ describe('WebSocketGateway', () => {
ws = io(`http://localhost:3000`);
const eventSource = new EventSource(`http://localhost:3000/sse`);
await new Promise((resolve, reject) => {
await new Promise<void>((resolve, reject) => {
ws.on('connect', resolve);
ws.on('error', reject);
});

8
packages/websockets/adapters/ws-adapter.ts
View File

@@ -19,6 +19,10 @@ export abstract class AbstractWsAdapter<
protected readonly httpServer: any;
private _forceCloseConnections: boolean;
public set forceCloseConnections(value: boolean) {
this._forceCloseConnections = value;
}
constructor(appOrHttpServer?: INestApplicationContext | any) {
if (appOrHttpServer && appOrHttpServer instanceof NestApplication) {
this.httpServer = appOrHttpServer.getUnderlyingHttpServer();
@@ -27,10 +31,6 @@ export abstract class AbstractWsAdapter<
}
}
public set forceCloseConnections(value: boolean) {
this._forceCloseConnections = value;
}
public bindClientConnect(server: TServer, callback: Function) {
server.on(CONNECTION_EVENT, callback);
}