amirho/nest
1
0
Fork 0
mirror of https://github.com/nestjs/nest.git synced 2026-02-21 23:11:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(common): removed async keyword

Browse Source
This commit is contained in:
Chathula
2025-04-04 14:01:10 +02:00
parent 08840c57df
commit 1f20f52731
2 changed files with 27 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/common/pipes/file/file-type.validator.ts
View File

@@ -22,7 +22,7 @@ export class FileTypeValidator extends FileValidator<
return `Validation failed (expected type is ${this.validationOptions.fileType})`;
}
async isValid(file?: IFile): Promise<boolean> {
isValid(file?: IFile): boolean {
if (!this.validationOptions) {
return true;
}

52
packages/common/test/pipes/file/file-type.validator.spec.ts
View File

@@ -4,7 +4,7 @@ import { FileTypeValidator } from '../../../pipes';
describe('FileTypeValidator', () => {
describe('isValid', () => {
it('should return true when the file buffer matches the specified type', async () => {
it('should return true when the file buffer matches the specified type', () => {
const fileTypeValidator = new FileTypeValidator({
fileType: 'image/jpeg',
});
@@ -17,10 +17,10 @@ describe('FileTypeValidator', () => {
buffer: jpegBuffer,
} as IFile;
expect(await fileTypeValidator.isValid(requestFile)).to.equal(true);
expect(fileTypeValidator.isValid(requestFile)).to.equal(true);
});
it('should return true when the file buffer matches the specified file extension', async () => {
it('should return true when the file buffer matches the specified file extension', () => {
const fileTypeValidator = new FileTypeValidator({
fileType: 'jpeg',
});
@@ -32,10 +32,10 @@ describe('FileTypeValidator', () => {
mimetype: 'image/jpeg',
buffer: jpegBuffer,
} as IFile;
expect(await fileTypeValidator.isValid(requestFile)).to.equal(true);
expect(fileTypeValidator.isValid(requestFile)).to.equal(true);
});
it('should return true when the file buffer matches the specified regexp', async () => {
it('should return true when the file buffer matches the specified regexp', () => {
const fileTypeValidator = new FileTypeValidator({
fileType: /^image\//,
});
@@ -48,10 +48,10 @@ describe('FileTypeValidator', () => {
buffer: jpegBuffer,
} as IFile;
expect(await fileTypeValidator.isValid(requestFile)).to.equal(true);
expect(fileTypeValidator.isValid(requestFile)).to.equal(true);
});
it('should return false when the file buffer does not match the specified type', async () => {
it('should return false when the file buffer does not match the specified type', () => {
const fileTypeValidator = new FileTypeValidator({
fileType: 'image/jpeg',
});
@@ -64,10 +64,10 @@ describe('FileTypeValidator', () => {
buffer: pngBuffer,
} as IFile;
expect(await fileTypeValidator.isValid(requestFile)).to.equal(false);
expect(fileTypeValidator.isValid(requestFile)).to.equal(false);
});
it('should return false when the file buffer does not match the specified file extension', async () => {
it('should return false when the file buffer does not match the specified file extension', () => {
const fileTypeValidator = new FileTypeValidator({
fileType: 'jpeg',
});
@@ -80,10 +80,10 @@ describe('FileTypeValidator', () => {
buffer: pngBuffer,
} as IFile;
expect(await fileTypeValidator.isValid(requestFile)).to.equal(false);
expect(fileTypeValidator.isValid(requestFile)).to.equal(false);
});
it('should return false when no buffer is provided', async () => {
it('should return false when no buffer is provided', () => {
const fileTypeValidator = new FileTypeValidator({
fileType: 'image/jpeg',
});
@@ -92,18 +92,18 @@ describe('FileTypeValidator', () => {
mimetype: 'image/jpeg',
} as IFile;
expect(await fileTypeValidator.isValid(requestFile)).to.equal(false);
expect(fileTypeValidator.isValid(requestFile)).to.equal(false);
});
it('should return false when no file is provided', async () => {
it('should return false when no file is provided', () => {
const fileTypeValidator = new FileTypeValidator({
fileType: 'image/jpeg',
});
expect(await fileTypeValidator.isValid()).to.equal(false);
expect(fileTypeValidator.isValid()).to.equal(false);
});
it('should return false when no buffer is provided', async () => {
it('should return false when no buffer is provided', () => {
const fileTypeValidator = new FileTypeValidator({
fileType: 'image/jpeg',
});
@@ -112,10 +112,10 @@ describe('FileTypeValidator', () => {
mimetype: 'image/jpeg',
} as IFile;
expect(await fileTypeValidator.isValid(requestFile)).to.equal(false);
expect(fileTypeValidator.isValid(requestFile)).to.equal(false);
});
it('should return true when the file buffer matches the specified regexp', async () => {
it('should return true when the file buffer matches the specified regexp', () => {
const fileTypeValidator = new FileTypeValidator({
fileType: /^image\//,
});
@@ -128,10 +128,10 @@ describe('FileTypeValidator', () => {
buffer: jpegBuffer,
} as IFile;
expect(await fileTypeValidator.isValid(requestFile)).to.equal(true);
expect(fileTypeValidator.isValid(requestFile)).to.equal(true);
});
it('should return true when no validation options are provided', async () => {
it('should return true when no validation options are provided', () => {
const fileTypeValidator = new FileTypeValidator({} as any);
const jpegBuffer = Buffer.from([
0xff, 0xd8, 0xff, 0xe0, 0x00, 0x10, 0x4a, 0x46, 0x49, 0x46,
@@ -141,10 +141,10 @@ describe('FileTypeValidator', () => {
buffer: jpegBuffer,
} as IFile;
expect(await fileTypeValidator.isValid(requestFile)).to.equal(true);
expect(fileTypeValidator.isValid(requestFile)).to.equal(true);
});
it('should skip magic numbers validation when the skipMagicNumbersValidation is true', async () => {
it('should skip magic numbers validation when the skipMagicNumbersValidation is true', () => {
const fileTypeValidator = new FileTypeValidator({
fileType: 'image/jpeg',
skipMagicNumbersValidation: true,
@@ -154,10 +154,10 @@ describe('FileTypeValidator', () => {
mimetype: 'image/jpeg',
} as IFile;
expect(await fileTypeValidator.isValid(requestFile)).to.equal(true);
expect(fileTypeValidator.isValid(requestFile)).to.equal(true);
});
it('should return false when the file buffer does not match any known type', async () => {
it('should return false when the file buffer does not match any known type', () => {
const fileTypeValidator = new FileTypeValidator({
fileType: 'unknown/type',
});
@@ -170,10 +170,10 @@ describe('FileTypeValidator', () => {
buffer: unknownBuffer,
} as IFile;
expect(await fileTypeValidator.isValid(requestFile)).to.equal(false);
expect(fileTypeValidator.isValid(requestFile)).to.equal(false);
});
it('should return false when the buffer is empty', async () => {
it('should return false when the buffer is empty', () => {
const fileTypeValidator = new FileTypeValidator({
fileType: 'image/jpeg',
});
@@ -184,7 +184,7 @@ describe('FileTypeValidator', () => {
buffer: emptyBuffer,
} as IFile;
expect(await fileTypeValidator.isValid(requestFile)).to.equal(false);
expect(fileTypeValidator.isValid(requestFile)).to.equal(false);
});
});